From: Tobias Burnus <tobias@codesourcery.com>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: error recovery on invalid CLASS(), PARAMETER declarations [PR105243]
Date: Thu, 30 Jun 2022 11:58:07 +0200 [thread overview]
Message-ID: <95dd0895-4c93-5f69-cfc0-aa054e7f18bb@codesourcery.com> (raw)
In-Reply-To: <trinity-d670ef07-b76b-4cd8-8690-2d4c7ff4d4fa-1656532446597@3c-app-gmx-bs60>
Dear Harald, dear all,
On 29.06.22 21:54, Harald Anlauf via Fortran wrote:
> a CLASS entity cannot have the PARAMETER attribute.
> This is detected in some situations, but in others
> we ICE because we never reach the existing check.
> Adding a similar check when handling the declaration
> improves error recovery.
>
> The initial patch is by Steve. I adjusted and moved
> it slightly so that it also handles CLASS(*)
> (unlimited polymorphic) at the same time.
Shouldn't you then also acknowledge him, e.g. via Co-authored-by?
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
OK. Thanks for the patch!
> This patch actually addresses multiple PRs, some of
> which are marked as regressions. As I consider the
> patch safe, I would like to backport to open branches
> as far as it seems appropriate.
Fine with me.
Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next prev parent reply other threads:[~2022-06-30 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 19:54 Harald Anlauf
2022-06-30 9:58 ` Tobias Burnus [this message]
2022-06-30 19:52 ` Harald Anlauf
2022-06-30 19:52 ` Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95dd0895-4c93-5f69-cfc0-aa054e7f18bb@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).