public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>,
	"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, fortran] PR67740 - Wrong association status of allocatable character pointer in derived types
Date: Wed, 11 Oct 2023 21:06:40 +0200	[thread overview]
Message-ID: <9d99ec10-3dd9-4af5-b330-f839ac601165@gmx.de> (raw)
In-Reply-To: <CAGkQGi+NVx6b0ZtQ7gK8wHAA1o0Rrr6JUy82H0xV0gfv7VqcvQ@mail.gmail.com>

Hi Paul,

On 10/11/23 10:48, Paul Richard Thomas wrote:
> Hi All,
>
> The title line of the PR should have been changed a long time since. As
> noted in comment 5, the original problem was fixed in 10.5.
>
> This patch fixes the problem described in comments 4 and 6, where the
> hidden string length component was not being set in pointer assignment of
> character arrays.
>
> The fix regtests. OK for trunk and 13-branch?

this is OK for both.

I'd suggest to wait a couple of days or a week before backporting.

Thanks for the patch!

Harald

> Thanks are due to Harald for bringing this to my attention.
>
> Paul
>
> Fortran: Set hidden string length for pointer components [PR67440]
>
> 2023-10-11  Paul Thomas  <pault@gcc.gnu.org>
>
> gcc/fortran
> PR fortran/pr67740
> * trans-expr.cc (gfc_trans_pointer_assignment): Set the hidden
> string length component for pointer assignment to character
> pointer components.
>
> gcc/testsuite/
> PR fortran/87477
> * gfortran.dg/pr67740.f90: New test
>


  reply	other threads:[~2023-10-11 19:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11  8:48 Paul Richard Thomas
2023-10-11 19:06 ` Harald Anlauf [this message]
2023-10-11 19:21   ` Harald Anlauf
2023-10-11 22:21     ` Paul Richard Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d99ec10-3dd9-4af5-b330-f839ac601165@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=paul.richard.thomas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).