* Windows test failure: dec_io_2.f90
@ 2017-03-28 22:54 NightStrike
2017-03-29 0:47 ` Jerry DeLisle
0 siblings, 1 reply; 6+ messages in thread
From: NightStrike @ 2017-03-28 22:54 UTC (permalink / raw)
To: fortran
On Windows platforms, the test for dec_io_2.f90 fails when calling the
second line in this trio:
call check_cc('none', fname, output_ccnone)
call check_cc('list', fname, output_cclist)
call check_cc('fortran', fname, output_ccfort)
Commenting the second line out makes it not abort. It aborts because
the test is expecting that the output file should have unix based line
endings (LF). On Windows platforms, it gets Windows based line
endings (CRLF).
Is the test wrong in its assumption of what the line endings should be
for output_cclist?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Windows test failure: dec_io_2.f90
2017-03-28 22:54 Windows test failure: dec_io_2.f90 NightStrike
@ 2017-03-29 0:47 ` Jerry DeLisle
2017-03-29 5:00 ` Steve Kargl
0 siblings, 1 reply; 6+ messages in thread
From: Jerry DeLisle @ 2017-03-29 0:47 UTC (permalink / raw)
To: NightStrike, fortran
On 03/28/2017 03:54 PM, NightStrike wrote:
> On Windows platforms, the test for dec_io_2.f90 fails when calling the
> second line in this trio:
>
> call check_cc('none', fname, output_ccnone)
> call check_cc('list', fname, output_cclist)
> call check_cc('fortran', fname, output_ccfort)
>
> Commenting the second line out makes it not abort. It aborts because
> the test is expecting that the output file should have unix based line
> endings (LF). On Windows platforms, it gets Windows based line
> endings (CRLF).
>
> Is the test wrong in its assumption of what the line endings should be
> for output_cclist?
>
I think so, the test is using stream io to read the raw content of the file
which will read the CRLF. The expected string does not contain the CRLF sequence.
Please file a PR for this. We can either XFAIL it or modify the test.
Jerry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Windows test failure: dec_io_2.f90
2017-03-29 0:47 ` Jerry DeLisle
@ 2017-03-29 5:00 ` Steve Kargl
2017-03-29 6:10 ` Janne Blomqvist
0 siblings, 1 reply; 6+ messages in thread
From: Steve Kargl @ 2017-03-29 5:00 UTC (permalink / raw)
To: Jerry DeLisle; +Cc: NightStrike, fortran
On Tue, Mar 28, 2017 at 05:47:52PM -0700, Jerry DeLisle wrote:
> On 03/28/2017 03:54 PM, NightStrike wrote:
> > On Windows platforms, the test for dec_io_2.f90 fails when calling the
> > second line in this trio:
> >
> > call check_cc('none', fname, output_ccnone)
> > call check_cc('list', fname, output_cclist)
> > call check_cc('fortran', fname, output_ccfort)
> >
> > Commenting the second line out makes it not abort. It aborts because
> > the test is expecting that the output file should have unix based line
> > endings (LF). On Windows platforms, it gets Windows based line
> > endings (CRLF).
> >
> > Is the test wrong in its assumption of what the line endings should be
> > for output_cclist?
> >
>
> I think so, the test is using stream io to read the raw content of the file
> which will read the CRLF. The expected string does not contain the CRLF sequence.
>
> Please file a PR for this. We can either XFAIL it or modify the test.
>
Just XFAIL the testcase. It is testing a DEC Fortran extension.
I doubt anyone has ever run a DEC Fortran compiler on a Microsoft
system.
--
Steve
20161221 https://www.youtube.com/watch?v=IbCHE-hONow
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Windows test failure: dec_io_2.f90
2017-03-29 5:00 ` Steve Kargl
@ 2017-03-29 6:10 ` Janne Blomqvist
2017-03-29 14:22 ` NightStrike
0 siblings, 1 reply; 6+ messages in thread
From: Janne Blomqvist @ 2017-03-29 6:10 UTC (permalink / raw)
To: Steve Kargl; +Cc: Jerry DeLisle, NightStrike, fortran
On Wed, Mar 29, 2017 at 8:00 AM, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Tue, Mar 28, 2017 at 05:47:52PM -0700, Jerry DeLisle wrote:
>> On 03/28/2017 03:54 PM, NightStrike wrote:
>> > On Windows platforms, the test for dec_io_2.f90 fails when calling the
>> > second line in this trio:
>> >
>> > call check_cc('none', fname, output_ccnone)
>> > call check_cc('list', fname, output_cclist)
>> > call check_cc('fortran', fname, output_ccfort)
>> >
>> > Commenting the second line out makes it not abort. It aborts because
>> > the test is expecting that the output file should have unix based line
>> > endings (LF). On Windows platforms, it gets Windows based line
>> > endings (CRLF).
>> >
>> > Is the test wrong in its assumption of what the line endings should be
>> > for output_cclist?
>> >
>>
>> I think so, the test is using stream io to read the raw content of the file
>> which will read the CRLF. The expected string does not contain the CRLF sequence.
>>
>> Please file a PR for this. We can either XFAIL it or modify the test.
>>
>
> Just XFAIL the testcase. It is testing a DEC Fortran extension.
> I doubt anyone has ever run a DEC Fortran compiler on a Microsoft
> system.
I don't recall the details, but IIRC DEC produced a windows version of
their fortran compiler called "DEC Visual Fortran" (DVF). Later the
DEC Fortran group was bought by Intel and DVF became Intel Fortran.
And, I believe Intel Fortran still supports all kinds of DEC
extensions. So, if we're going to support DEC extensions at all
(personally, I'm somewhat ambivalent, but hey, the code is written
already so why not...), I don't see any particular reason to not
support them on Windows (beyond the usual problem that AFAIK none of
the GFortran regulars develop or test on Windows targets).
--
Janne Blomqvist
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Windows test failure: dec_io_2.f90
2017-03-29 6:10 ` Janne Blomqvist
@ 2017-03-29 14:22 ` NightStrike
2017-03-29 17:35 ` Thomas Koenig
0 siblings, 1 reply; 6+ messages in thread
From: NightStrike @ 2017-03-29 14:22 UTC (permalink / raw)
To: Janne Blomqvist; +Cc: Steve Kargl, Jerry DeLisle, fortran
On Wed, Mar 29, 2017 at 2:10 AM, Janne Blomqvist
<blomqvist.janne@gmail.com> wrote:
> On Wed, Mar 29, 2017 at 8:00 AM, Steve Kargl
> <sgk@troutmask.apl.washington.edu> wrote:
>> On Tue, Mar 28, 2017 at 05:47:52PM -0700, Jerry DeLisle wrote:
>>> On 03/28/2017 03:54 PM, NightStrike wrote:
>>> > On Windows platforms, the test for dec_io_2.f90 fails when calling the
>>> > second line in this trio:
>>> >
>>> > call check_cc('none', fname, output_ccnone)
>>> > call check_cc('list', fname, output_cclist)
>>> > call check_cc('fortran', fname, output_ccfort)
>>> >
>>> > Commenting the second line out makes it not abort. It aborts because
>>> > the test is expecting that the output file should have unix based line
>>> > endings (LF). On Windows platforms, it gets Windows based line
>>> > endings (CRLF).
>>> >
>>> > Is the test wrong in its assumption of what the line endings should be
>>> > for output_cclist?
>>>
>>> I think so, the test is using stream io to read the raw content of the file
>>> which will read the CRLF. The expected string does not contain the CRLF sequence.
>>>
>>> Please file a PR for this. We can either XFAIL it or modify the test.
>>
>> Just XFAIL the testcase. It is testing a DEC Fortran extension.
>> I doubt anyone has ever run a DEC Fortran compiler on a Microsoft
>> system.
>
> I don't recall the details, but IIRC DEC produced a windows version of
> their fortran compiler called "DEC Visual Fortran" (DVF). Later the
> DEC Fortran group was bought by Intel and DVF became Intel Fortran.
> And, I believe Intel Fortran still supports all kinds of DEC
> extensions. So, if we're going to support DEC extensions at all
> (personally, I'm somewhat ambivalent, but hey, the code is written
> already so why not...), I don't see any particular reason to not
> support them on Windows (beyond the usual problem that AFAIK none of
> the GFortran regulars develop or test on Windows targets).
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Windows test failure: dec_io_2.f90
2017-03-29 14:22 ` NightStrike
@ 2017-03-29 17:35 ` Thomas Koenig
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Koenig @ 2017-03-29 17:35 UTC (permalink / raw)
To: NightStrike, Janne Blomqvist; +Cc: Steve Kargl, Jerry DeLisle, fortran
Am 29.03.2017 um 16:21 schrieb NightStrike:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254
Fixed as obvious by creating a mingw-specific test case
and making sure that the new one is run on MINGW and the
old one everywhere else. Thanks to NightStrike for testing.
Regards
Thomas
Author: tkoenig
Date: Wed Mar 29 17:30:58 2017
New Revision: 246573
URL: https://gcc.gnu.org/viewcvs?rev=246573&root=gcc&view=rev
Log:
2017-03-28 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/80254
* gfortran.dg/dec_io_2.f90: Do not run on MINGW, run
* gfortran.dg/dec_io_2a.f90: instead (new test).
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-29 17:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 22:54 Windows test failure: dec_io_2.f90 NightStrike
2017-03-29 0:47 ` Jerry DeLisle
2017-03-29 5:00 ` Steve Kargl
2017-03-29 6:10 ` Janne Blomqvist
2017-03-29 14:22 ` NightStrike
2017-03-29 17:35 ` Thomas Koenig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).