From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Jerry D <jvdelisle2@gmail.com>
Cc: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] testsuite: fix scan-tree-dump patterns [PR83904, PR100297]
Date: Wed, 19 Apr 2023 17:14:42 +0200 [thread overview]
Message-ID: <CAC1BbcT2aRgZM04-iMeG5fjpnrmJC5Hjj=4yUB84uJeY-G3byQ@mail.gmail.com> (raw)
In-Reply-To: <a3394ed6-95de-c2ec-5040-60e1a4f71bb0@gmail.com>
On Wed, 19 Apr 2023 at 03:03, Jerry D via Fortran <fortran@gcc.gnu.org> wrote:
>
> On 4/18/23 12:39 PM, Harald Anlauf via Fortran wrote:
> > Dear all,
> >
> > the attached patch adjusts the scan-tree-dump patterns of the
> > reported testcases which likely were run in a location such
> > that a path in an error message showing in the tree-dump might
> > have accidentally matched "free" or "data", respectively.
> >
> > For the testcase gfortran.dg/reshape_8.f90 I checked with a
> > failing gfortran-11 that the pattern is appropriate.
> >
> > OK for mainline?
> >
> > Thanks,
> > Harald
> >
> Yes, OK
I'm certainly not opposed to this specific incarnation of such a fix.
These failures are really unpleasant :)
As proposed in https://inbox.sourceware.org/gcc-patches/20220426010029.2b476337@nbbrfq/
we could add a -fno-file to suppress the assembler .file output
(whatever the prefix looks like depends on the assembler dialect). Or
we could nuke the .file directives by a sed(1), but that would
probably be cumbersome for remote targets. I don't have a better idea
than -fno-file or -ffile=foo.c .
Fixing them case-by-case does not scale all that well IMHO.
Thoughts?
next prev parent reply other threads:[~2023-04-19 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 19:39 [PATCH] testsuite: fix scan-tree-dump patterns [PR83904,PR100297] Harald Anlauf
2023-04-19 1:03 ` Jerry D
2023-04-19 15:14 ` Bernhard Reutner-Fischer [this message]
2023-04-19 16:34 ` [PATCH] testsuite: fix scan-tree-dump patterns [PR83904, PR100297] Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC1BbcT2aRgZM04-iMeG5fjpnrmJC5Hjj=4yUB84uJeY-G3byQ@mail.gmail.com' \
--to=rep.dot.nop@gmail.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jvdelisle2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).