From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Harald Anlauf <anlauf@gmx.de>
Cc: fortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/99112 - [11 Regression] ICE with runtime diagnostics for SIZE intrinsic function
Date: Sat, 13 Mar 2021 08:58:53 +0000 [thread overview]
Message-ID: <CAGkQGiKO0=nJQ6--2QO=+jE74ec7dH=6JCoLbNzf+r0oJjYX4Q@mail.gmail.com> (raw)
In-Reply-To: <trinity-08750272-2a63-4c66-9902-107a0a1cceb1-1615581794502@3c-app-gmx-bap22>
Hi Harald,
I am not sure of the etiquette for this - it looks OK to me :-)
Cheers
Paul
On Fri, 12 Mar 2021 at 21:20, Harald Anlauf via Fortran <fortran@gcc.gnu.org>
wrote:
> Dear all,
>
> the addition of runtime checks for the SIZE intrinsic created a regression
> that showed up for certain CLASS arguments to procedures. Paul did most of
> the work (~ 99%), but asked me to dig into an issue with an inappropriately
> selected error message. This actually turned out to be a simple one-liner
> on top of Paul's patch.
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
>
> Thanks,
> Harald
>
> P.S.: I couldn't find a Changelog entry that uses co-authors. Is the
> version
> below correct?
>
>
> PR fortran/99112 - ICE with runtime diagnostics for SIZE intrinsic function
>
> Add/fix handling of runtime checks for CLASS arguments with ALLOCATABLE
> or POINTER attribute.
>
> gcc/fortran/ChangeLog:
>
> * trans-expr.c (gfc_conv_procedure_call): Fix runtime checks for
> CLASS arguments.
> * trans-intrinsic.c (gfc_conv_intrinsic_size): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> * gfortran.dg/pr99112.f90: New test.
>
> Co-authored-by: Paul Thomas <pault@gcc.gnu.org>
>
>
--
"If you can't explain it simply, you don't understand it well enough" -
Albert Einstein
next prev parent reply other threads:[~2021-03-13 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 20:43 Harald Anlauf
2021-03-13 8:58 ` Paul Richard Thomas [this message]
2021-03-14 10:56 ` Tobias Burnus
2021-03-14 19:54 ` Aw: " Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGkQGiKO0=nJQ6--2QO=+jE74ec7dH=6JCoLbNzf+r0oJjYX4Q@mail.gmail.com' \
--to=paul.richard.thomas@gmail.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).