From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] Fortran: Extend align-clause checks of OpenMP's allocate clause
Date: Tue, 31 Jan 2023 12:44:40 +0100 [thread overview]
Message-ID: <Y9j/KBlFloJ6pPYy@tucnak> (raw)
In-Reply-To: <fa14a602-d3d2-c5f7-a5d6-62aff32b7b7e@codesourcery.com>
On Tue, Dec 13, 2022 at 05:38:22PM +0100, Tobias Burnus wrote:
> I missed that 'align' needs to be a power of 2 - contrary to 'aligned',
> which does not have this restriction for some odd reason.
Yeah, odd. The C and C++ FEs indeed diagnose non-pow2p constants
for align (and not for aligned clause).
>
> OK for mainline?
Yes, thanks. Sorry for the delay.
> Fortran: Extend align-clause checks of OpenMP's allocate directive
>
> gcc/fortran/ChangeLog:
>
> * openmp.cc (resolve_omp_clauses): Check also for
> power of two.
>
> libgomp/ChangeLog:
>
> * testsuite/libgomp.fortran/allocate-3.f90: Fix ALIGN
> usage, remove unused -fdump-tree-original.
> * testsuite/libgomp.fortran/allocate-4.f90: New.
Jakub
prev parent reply other threads:[~2023-01-31 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 16:38 Tobias Burnus
2023-01-31 11:44 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9j/KBlFloJ6pPYy@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).