From: Jakub Jelinek <jakub@redhat.com>
To: Mikael Morin <morin-mikael@orange.fr>
Cc: Kwok Cheung Yeung <kcy@codesourcery.com>,
Tobias Burnus <tobias@codesourcery.com>,
gscfq@t-online.de, gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>
Subject: Re: [PATCH] openmp, fortran: Check that event handles passed to detach clauses are not arrays [PR104131]
Date: Mon, 28 Feb 2022 18:37:15 +0100 [thread overview]
Message-ID: <Yh0IS7FQxufDFSM2@tucnak> (raw)
In-Reply-To: <8981ebb8-7b8e-19d7-a3b3-ef5fce239c53@orange.fr>
On Mon, Feb 28, 2022 at 06:33:15PM +0100, Mikael Morin wrote:
> > It is true that the spots I saw in fortran/openmp.cc that test rank look
> > like:
> > if (!gfc_resolve_expr (el->expr)
> > || el->expr->ts.type != BT_INTEGER || el->expr->rank != 0)
> > etc., so probably !gfc_resolve_expr call is missing.
> >
> As long as the expression is expected to not be a (contained) function call,
> I think it should work.
>
> In the general case non-syntaxic errors are preferably checked and reported
> later at resolution stage, where contained functions are known.
Oh, I've missed that it is done during parsing and not during resolution.
That !gfc_resolve_expr call and the checking if it is BT_INTEGER etc.
should be certainly moved to resolve_omp_clauses.
Jakub
next prev parent reply other threads:[~2022-02-28 17:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 14:01 Kwok Cheung Yeung
2022-02-28 14:07 ` Jakub Jelinek
2022-02-28 14:27 ` Kwok Cheung Yeung
2022-02-28 15:54 ` Mikael Morin
2022-02-28 16:00 ` Jakub Jelinek
2022-02-28 17:33 ` Mikael Morin
2022-02-28 17:37 ` Jakub Jelinek [this message]
2022-02-28 18:38 ` Kwok Cheung Yeung
2022-02-28 20:37 ` Mikael Morin
2022-02-28 20:45 ` Mikael Morin
2022-02-28 21:37 ` Jakub Jelinek
2022-02-28 22:36 ` Mikael Morin
2022-03-01 7:58 ` Tobias Burnus
2022-03-01 8:16 ` Jakub Jelinek
2022-03-01 9:17 ` Tobias Burnus
2022-03-01 15:37 ` Mikael Morin
2022-03-02 17:22 ` [PATCH][v2] openmp, fortran: Check that the type of an event handle in a detach clause is suitable [PR104131] Kwok Cheung Yeung
2022-03-02 17:31 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh0IS7FQxufDFSM2@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gscfq@t-online.de \
--cc=kcy@codesourcery.com \
--cc=morin-mikael@orange.fr \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).