From: Jakub Jelinek <jakub@redhat.com>
To: Kwok Cheung Yeung <kcy@codesourcery.com>
Cc: Mikael Morin <morin-mikael@orange.fr>,
Tobias Burnus <tobias@codesourcery.com>,
gscfq@t-online.de, gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>
Subject: Re: [PATCH][v2] openmp, fortran: Check that the type of an event handle in a detach clause is suitable [PR104131]
Date: Wed, 2 Mar 2022 18:31:12 +0100 [thread overview]
Message-ID: <Yh+p4KWhUemKwxpe@tucnak> (raw)
In-Reply-To: <262035c6-7039-84c5-0b61-b9ee98f24b23@codesourcery.com>
On Wed, Mar 02, 2022 at 05:22:21PM +0000, Kwok Cheung Yeung wrote:
> I have updated the patch to catch array elements and structure components as
> additional checks, in addition to checking that the variable is a scalar.
>
> The check has been moved to the end of resolve_omp_clauses as it is more
> appropriate there. This gets rid of the additional 'Unexpected !$OMP END
> TASK statement' error, since the type error is now caught after the matching
> phase.
>
> Coarrays (with the testcases in pr104131-2.f90) can be dealt with in a
> separate patch. Is this part okay for trunk?
LGTM, thanks.
Yes, coarrays is something that we need to deal with in all the clauses,
not just this one, so before we claim OpenMP 5.0 support we need to go
through it fully.
Jakub
prev parent reply other threads:[~2022-03-02 17:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 14:01 [PATCH] openmp, fortran: Check that event handles passed to detach clauses are not arrays [PR104131] Kwok Cheung Yeung
2022-02-28 14:07 ` Jakub Jelinek
2022-02-28 14:27 ` Kwok Cheung Yeung
2022-02-28 15:54 ` Mikael Morin
2022-02-28 16:00 ` Jakub Jelinek
2022-02-28 17:33 ` Mikael Morin
2022-02-28 17:37 ` Jakub Jelinek
2022-02-28 18:38 ` Kwok Cheung Yeung
2022-02-28 20:37 ` Mikael Morin
2022-02-28 20:45 ` Mikael Morin
2022-02-28 21:37 ` Jakub Jelinek
2022-02-28 22:36 ` Mikael Morin
2022-03-01 7:58 ` Tobias Burnus
2022-03-01 8:16 ` Jakub Jelinek
2022-03-01 9:17 ` Tobias Burnus
2022-03-01 15:37 ` Mikael Morin
2022-03-02 17:22 ` [PATCH][v2] openmp, fortran: Check that the type of an event handle in a detach clause is suitable [PR104131] Kwok Cheung Yeung
2022-03-02 17:31 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh+p4KWhUemKwxpe@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gscfq@t-online.de \
--cc=kcy@codesourcery.com \
--cc=morin-mikael@orange.fr \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).