From: Jakub Jelinek <jakub@redhat.com>
To: Hafiz Abid Qadeer <abidh@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org
Subject: Re: [PATCH] Add a restriction on allocate clause (OpenMP 5.0)
Date: Wed, 4 May 2022 18:53:30 +0200 [thread overview]
Message-ID: <YnKvissh/qhkX1PS@tucnak> (raw)
In-Reply-To: <20220218231316.3186096-1-abidh@codesourcery.com>
On Fri, Feb 18, 2022 at 11:13:16PM +0000, Hafiz Abid Qadeer wrote:
> An allocate clause in target region must specify an allocator
> unless the compilation unit has requires construct with
> dynamic_allocators clause. Current implementation of the allocate
> clause did not check for this restriction. This patch fills that
> gap.
>
> gcc/ChangeLog:
>
> * omp-low.cc (omp_maybe_offloaded_ctx): New prototype.
> (scan_sharing_clauses): Check a restriction on allocate clause.
>
> gcc/testsuite/ChangeLog:
>
> * c-c++-common/gomp/allocate-2.c: Add tests.
> * c-c++-common/gomp/allocate-8.c: New test.
> * gfortran.dg/gomp/allocate-3.f90: Add tests.
> * gcc.dg/gomp/pr104517.c: Update.
I think it has even stronger requirement, that the allocator is present
and is present in uses_allocators clause.
But we don't parse uses_allocators, so this is a good step forward.
Ok.
Jakub
prev parent reply other threads:[~2022-05-04 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 23:13 Hafiz Abid Qadeer
2022-05-04 16:53 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnKvissh/qhkX1PS@tucnak \
--to=jakub@redhat.com \
--cc=abidh@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).