public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: Mikael Morin <morin-mikael@orange.fr>,
	fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org,
	Harald Anlauf <anlauf@gmx.de>,
	"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [PATCH] fortran, libgfortran, v3: Avoid using libquadmath for glibc 2.26+
Date: Tue, 28 Jun 2022 12:57:11 +0200	[thread overview]
Message-ID: <Yrreh9Ai9QRWTtJ/@tucnak> (raw)
In-Reply-To: <01d38605-13f7-d785-a461-1c6826550b4e@codesourcery.com>

On Tue, Jun 28, 2022 at 10:35:03AM +0200, Tobias Burnus wrote:
> On 27.06.22 15:30, Jakub Jelinek via Gcc-patches wrote:
> 
> > Ok, here is an updated patch that uses _Float128/_Complex _Float128 for all
> > of GFC_REAL_{16,17}_IS_FLOAT128, but still uses q/Q suffixes on literal
> > constants etc. when using libquadmath and f128/F128 otherwise.
> > This patch also includes the incremental powerpc64le fixes.
> > 
> > Ok if it passes testing?
> 
> LGTM – I am not completely happy of having a TARGET_GLIBC_M{AJ,IN}OR check
> in the FE

I've used it because it is already (though my fault too) used for the
powerpc64le stuff in the FE too.
The alternative would be grepping of target glibc headers in
gcc/configure.ac, because I think we can't during gcc configure time
preprocess the target glibc header (at least not reliably) because
at that point we just have host compiler which might be a different
architecture.  So, we could e.g. grep for
grep '^[[:blank:]]*#[[:blank:]]*define[[:blank:]]*__HAVE_FLOAT128[[:blank:]]*1' $target_header_dir/bits/floatn.h
or so.
Currently all arches that do have the IEC 60559 _Float128 *f128 APIs
in glibc were added in glibc 2.26, if some extra are added later
or some other libraries add those, we can always improve the checks.

	Jakub


  reply	other threads:[~2022-06-28 10:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23 12:04 [PATCH] fortran, libgfortran: " Jakub Jelinek
2022-06-23 20:49 ` Harald Anlauf
2022-06-23 21:17   ` Jakub Jelinek
2022-06-24 10:29     ` [PATCH] fortran, libgfortran, v2: " Jakub Jelinek
2022-06-24 21:06       ` Harald Anlauf
2022-06-26 18:45       ` Mikael Morin
2022-06-27  7:54         ` Jakub Jelinek
2022-06-27 11:56           ` Mikael Morin
2022-06-27 13:30             ` [PATCH] fortran, libgfortran, v3: " Jakub Jelinek
2022-06-28  7:01               ` Jakub Jelinek
2022-06-28  8:35               ` Tobias Burnus
2022-06-28 10:57                 ` Jakub Jelinek [this message]
2022-06-27 20:54           ` [PATCH] fortran, libgfortran, v2: " Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yrreh9Ai9QRWTtJ/@tucnak \
    --to=jakub@redhat.com \
    --cc=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=morin-mikael@orange.fr \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).