From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: fortran@gcc.gnu.org
Subject: Need a hint or more likely help
Date: Sat, 10 Feb 2024 18:00:42 -0800 [thread overview]
Message-ID: <ZcgqSmfPcqKXlpzQ@troutmask.apl.washington.edu> (raw)
All, consider this simple code:
module foo
contains
subroutine bar
character(len=:), allocatable :: s(:)
call bah(s)
end subroutine bar
end module foo
If one compiles with -fdump-tree-original, one see (with some pruning)
void bar ()
{
integer(kind=8) .s;
struct array01_character(kind=1) s;
The above two lines seem to be ok.
bitsizetype D.4319;
sizetype D.4320;
try
{
D.4319 = (bitsizetype) (sizetype) NON_LVALUE_EXPR <.s> * 8;
D.4320 = (sizetype) NON_LVALUE_EXPR <.s>;
s.data = 0B;
s.dtype = {.elem_len=(unsigned long) .s, .version=0, .rank=1, .type=6};
bah ((character(kind=1)[0:][1:.s] * restrict) s.data, .s);
}
This is bad. .s is undefined. I've trace this to trans-array.cc:11531
if (sym->ts.type == BT_CHARACTER
&& !INTEGER_CST_P (sym->ts.u.cl->backend_decl))
{
gfc_conv_string_length (sym->ts.u.cl, NULL, &init);
gfc_trans_vla_type_sizes (sym, &init);
The problem here is that sym->ts.u.cl->length == NULL. If I change
the conditional to
if (sym->ts.type == BT_CHARACTER
&& sym->ts.u.cl->length
&& !INTEGER_CST_P (sym->ts.u.cl->backend_decl))
then the option -fdump-tree-original produces
void bar ()
{
integer(kind=8) .s;
struct array01_character(kind=1) s;
try
{
s.data = 0B;
s.dtype = {.elem_len=(unsigned long) .s, .version=0, .rank=1, .type=6};
bah ((character(kind=1)[0:][1:.s] * restrict) s.data, .s);
}
which looks good except I don't know what the reference to .s here
means. Is this correct or should we set .s to zero by artificially
setting sym->ts.u.cl->length to, say, zero length?
--
Steve
next reply other threads:[~2024-02-11 2:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 2:00 Steve Kargl [this message]
2024-02-11 7:02 ` Steve Kargl
2024-02-11 10:56 ` Mikael Morin
2024-02-11 17:40 ` Steve Kargl
2024-02-12 3:14 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcgqSmfPcqKXlpzQ@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).