From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: fortran@gcc.gnu.org
Subject: Re: Need a hint or more likely help
Date: Sun, 11 Feb 2024 19:14:34 -0800 [thread overview]
Message-ID: <ZcmNGnYdqpchJ-64@troutmask.apl.washington.edu> (raw)
In-Reply-To: <ZcgqSmfPcqKXlpzQ@troutmask.apl.washington.edu>
On Sat, Feb 10, 2024 at 06:00:42PM -0800, Steve Kargl wrote:
> All, consider this simple code:
>
> module foo
> contains
> subroutine bar
> character(len=:), allocatable :: s(:)
> call bah(s)
> end subroutine bar
> end module foo
>
> If one compiles with -fdump-tree-original, one see (with some pruning)
>
> void bar ()
> {
> integer(kind=8) .s;
> struct array01_character(kind=1) s;
>
> The above two lines seem to be ok.
>
> bitsizetype D.4319;
> sizetype D.4320;
>
> try
> {
> D.4319 = (bitsizetype) (sizetype) NON_LVALUE_EXPR <.s> * 8;
> D.4320 = (sizetype) NON_LVALUE_EXPR <.s>;
> s.data = 0B;
> s.dtype = {.elem_len=(unsigned long) .s, .version=0, .rank=1, .type=6};
> bah ((character(kind=1)[0:][1:.s] * restrict) s.data, .s);
> }
>
> This is bad. .s is undefined. I've trace this to trans-array.cc:11531
I have created PR113883 with the patch suggested by Mikael and
a testcase. I have bootstrapped and regression tested the result.
Could I ask someone to commit it?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113883
* trans-array.cc (gfc_trans_deferred_array): Set length of an unallocated
character entity to zero to prevent reference to undefined variable.
* testsuite/gfortran.dg/allocatable_length.f90: New test.
--
Steve
prev parent reply other threads:[~2024-02-12 3:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 2:00 Steve Kargl
2024-02-11 7:02 ` Steve Kargl
2024-02-11 10:56 ` Mikael Morin
2024-02-11 17:40 ` Steve Kargl
2024-02-12 3:14 ` Steve Kargl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcmNGnYdqpchJ-64@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).