From: Jerry D <jvdelisle2@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gfortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] testsuite: Fix up pr107397.f90 test [PR107397]
Date: Mon, 19 Dec 2022 18:07:55 -0800 [thread overview]
Message-ID: <a6b23d07-019b-eb15-123c-f101a7ba2498@gmail.com> (raw)
In-Reply-To: <Y6A9BBI4OAIb0s9a@tucnak>
On 12/19/22 2:29 AM, Jakub Jelinek wrote:
> On Sat, Dec 17, 2022 at 09:12:43AM -0800, Jerry D via Gcc-patches wrote:
>> The attached patch fixes a regression and is a patch from Steve. I have
>> regression tested it and provided a test case. It is fairly simple and I
>> will commit under the "simple" rule in a little while.
>>
>> Thanks Steve for Patch. Thanks Harald for helping me get back up to speed on
>> the git magic.
>
> The pr107397.f90 test FAILs for me, one problem was that the
> added diagnostics has an indefinite article before BOZ, but
> the test dg-error didn't. The other problem was that on the
> other dg-error there was no space between the string and closing
> }, so it was completely ignored and the error was an excess
> error.
>
> 2022-12-19 Jakub Jelinek <jakub@redhat.com>
>
> PR fortran/107397
> * gfortran.dg/pr107397.f90: Adjust expected diagnostic wording and
> add space between dg-error string and closing }.
=== snip ===
Thanks Jakub.
prev parent reply other threads:[~2022-12-20 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 17:12 [patch, fortran] PR107397 ICE in gfc_arith_plus, at fortran/arith.cc:654 Jerry D
2022-12-19 10:29 ` [committed] testsuite: Fix up pr107397.f90 test [PR107397] Jakub Jelinek
2022-12-20 2:07 ` Jerry D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6b23d07-019b-eb15-123c-f101a7ba2498@gmail.com \
--to=jvdelisle2@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).