Re: [patch, fortran] ICE in attr_decl1, at fortran/decl.c:8691

[Harald Anlauf <anlauf@gmx.de>]

Hi Jerry,

Am 26.12.22 um 23:26 schrieb Jerry DeLisle via Gcc-patches:
> The attached patch was provided by Steve Kargl.  After exploring for
> possible other checks I settled on leaving the patch intact.
>
> Two existing test cases updated as different but sensible error messages
> resulted.

I think this is fine.  The error message for CLASS is
now arguably more consistent with TYPE.

> Regression tested on main line.
>
> OK to commit?

Regarding the format of the commit message: if you want
bugzilla to get updated properly, please consider adding
PR/fortran ###### to the respective parts below.
It is also custom to have a one-line summary including
e.g. [PR######] to make it easier for others to relate
a commit to bugzilla.

OK with these things fixed.

Thanks for taking this!

Harald

> Regards,
>
> Jerry
>
> Author: Steve Kargl <kargl@gcc.gnu.org>
> Date:   Mon Dec 26 14:07:04 2022 -0800
>
>       Modify checks to avoid referencing NULL pointer.
>       Update test cases with error messages that changed as a result.
>
>       gcc/fortran/ChangeLog:
>
>               * decl.cc (attr_decl1): Guard against NULL pointer.
>               * parse.cc (match_deferred_characteristics): Include
> BT_CLASS in check for
>                 derived being undefined.
>
>       gcc/testsuite/ChangeLog:
>
>               * gfortran.dg/class_result_4.f90: Update error message check.
>               * gfortran.dg/pr85779_3.f90: Update error message check.