Re: [Patch] Fortran: OpenMP fix declare simd inside modules and absent linear step [PR106566]

[Tobias Burnus <tobias@codesourcery.com>]

On 17.08.22 15:09, Jakub Jelinek wrote:
> On Tue, Aug 16, 2022 at 04:45:07PM +0200, Tobias Burnus wrote:
>> Fortran: OpenMP fix declare simd inside modules and absent linear step [PR106566]
>> ...
> LGTM.
>
>> +! { dg-final { scan-tree-dump-times "__attribute__\\(\\(omp declare simd \\(linear\\(0:ref,step\\(4\\)\\) simdlen\\(8\\)\\)\\)\\)" 2 "gimple" } }
...
>> +  integer :: p
> Wonder if it wouldn't be better to use integer(kind=4) explicitly
> when you try to match the size of that multiplied by 1 or 2 in
> dg-final, as say with -fdefault-integer-8 this will fail miserably
> otherwise.  Ditto in other spots in this as well as other tests.

I assume(d) that no one would compile with -fdefault-integer-8.

But possibly it should be changed to permit testing with that flag,
given that API routines should be able to handle different default-kind
integers. On the other hand, API routines implies 'omp_lib', which is
only available in libgomp/testsuite/.

> Ok with/without that change.

Thanks for the review.

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955