From: Tobias Burnus <tobias@codesourcery.com>
To: Julian Brown <julian@codesourcery.com>
Cc: <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>,
<fortran@gcc.gnu.org>
Subject: Re: [PATCH 2/2] OpenMP: Duplicate checking for map clauses in Fortran (PR107214)
Date: Sat, 10 Dec 2022 13:48:01 +0100 [thread overview]
Message-ID: <ade5df9b-5e75-2dad-eb0d-54f604e720fa@codesourcery.com> (raw)
In-Reply-To: <20221210121022.73c2bb32@squid.athome>
Hi Julian,
On 10.12.22 13:10, Julian Brown wrote:
> On Thu, 8 Dec 2022 13:04:20 +0100
> Tobias Burnus <tobias@codesourcery.com> wrote:
>> All in all, I am fine with the patch - but I spotted some issues.
...
> I believe this patch covers all the above cases (hopefully
> appropriately generalised), at least for Fortran. I haven't attempted
> to fix any missing cases for C, for now.
>
> Re-tested with offloading to NVPTX (with a few supporting patches, as
> before).
>
> Does this look OK now?
Yes, LGTM.
Thanks!
Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next prev parent reply other threads:[~2022-12-10 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 16:14 [PATCH] " Julian Brown
2022-10-26 10:39 ` Tobias Burnus
2022-12-07 19:09 ` [PATCH 1/2] OpenMP/Fortran: Combined directives with map/firstprivate of same symbol Julian Brown
2022-12-07 19:13 ` [PATCH 2/2] OpenMP: Duplicate checking for map clauses in Fortran (PR107214) Julian Brown
2022-12-08 12:04 ` Tobias Burnus
2022-12-10 12:10 ` Julian Brown
2022-12-10 12:48 ` Tobias Burnus [this message]
2022-12-08 10:22 ` [PATCH 1/2] OpenMP/Fortran: Combined directives with map/firstprivate of same symbol Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ade5df9b-5e75-2dad-eb0d-54f604e720fa@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=julian@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).