From: Harald Anlauf <anlauf@gmx.de>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, fortran] PR103716 - [10/11/12/13/14 Regression] ICE in gimplify_expr, at gimplify.c:15964
Date: Tue, 9 May 2023 20:29:30 +0200 [thread overview]
Message-ID: <ba8e8456-9f65-aabf-a920-4dcfd9bdde7f@gmx.de> (raw)
In-Reply-To: <CAGkQGi+_uXXzYQfHsfTjvo7USx98JB_ufDFEwN8eLm=X1xEcDQ@mail.gmail.com>
Hi Paul,
On 5/9/23 18:00, Paul Richard Thomas via Gcc-patches wrote:
> Hi All,
>
> This problem caused the gimplifier failure because the reference chain
> ending in an inquiry_len still retained a full array reference. This had
> already been corrected for deferred character lengths but the fix extends
> this to all characters without a length expression and integer expressions,
> which is the correct type of course, that retain a full array_spec. The
> nullification of the se->string length in conv_inquiry is a
> belts-and-braces measure to stop it from winding up as a hidden argument in
> procedure calls.
>
> OK for trunk and, after a decent delay, backporting?
ENOTESTCASE.
Nevertheless the patch LGTM and is also OK for backporting.
Thanks for fixing this!
Harald
> Cheers
>
> Paul
>
> Fortran: Fix assumed length chars and len inquiry [PR103716]
>
> 2023-05-09 Paul Thomas <pault@gcc.gnu.org>
>
> gcc/fortran
> PR fortran/103716
> * resolve.cc (gfc_resolve_ref): Conversion of array_ref into an
> element should be done for all characters without a len expr,
> not just deferred lens, and for integer expressions.
> * trans-expr.cc (conv_inquiry): For len and kind inquiry refs,
> set the se string_length to NULL_TREE.
>
> gcc/testsuite/
> PR fortran/103716
> * gfortran.dg/pr103716 : New test.
next prev parent reply other threads:[~2023-05-09 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 16:00 Paul Richard Thomas
2023-05-09 18:29 ` Harald Anlauf [this message]
2023-05-09 20:25 ` Paul Richard Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba8e8456-9f65-aabf-a920-4dcfd9bdde7f@gmx.de \
--to=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=paul.richard.thomas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).