From: Mikael Morin <morin-mikael@orange.fr>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
gcc-patches@gcc.gnu.org
Cc: Bernhard Reutner-Fischer <aldot@gcc.gnu.org>,
gfortran ML <fortran@gcc.gnu.org>
Subject: Re: [PATCH 1/2] Fortran: Cleanup struct ext_attr_t
Date: Mon, 21 Nov 2022 12:08:20 +0100 [thread overview]
Message-ID: <c7af7c9b-f787-83c7-d1d4-d0ba4bd05035@orange.fr> (raw)
In-Reply-To: <20221110102031.1366016-2-aldot@gcc.gnu.org>
Hello,
Le 10/11/2022 à 11:20, Bernhard Reutner-Fischer via Fortran a écrit :
> Tiny cleanup opportunity since we now have ext_attr_args in
> struct symbol_attribute.
> Bootstrapped and regtested on x86_64-unknown-linux with no new
> regressions.
> Ok for trunk if the prerequisite was approved ([PATCH 2/2] Fortran: add
> attribute target_clones) ?
>
> gcc/fortran/ChangeLog:
>
> * gfortran.h (struct ext_attr_t): Remove middle_end_name.
> * trans-decl.cc (add_attributes_to_decl): Move building
> tree_list to ...
> * decl.cc (gfc_match_gcc_attributes): ... here. Add the attribute to
> the tree_list for the middle end.
>
I prefer to not do any middle-end stuff at parsing time, so I would
rather not do this change.
Not OK.
next prev parent reply other threads:[~2022-11-21 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 10:20 [PATCH 0/2] Fortran: Add attribute flatten Bernhard Reutner-Fischer
2022-11-10 10:20 ` [PATCH 1/2] Fortran: Cleanup struct ext_attr_t Bernhard Reutner-Fischer
2022-11-21 11:08 ` Mikael Morin [this message]
2022-11-21 20:34 ` Bernhard Reutner-Fischer
2022-11-22 11:52 ` Mikael Morin
2022-11-10 10:20 ` [PATCH 2/2] Fortran: Add attribute flatten Bernhard Reutner-Fischer
2022-11-21 11:24 ` Mikael Morin
2022-11-21 20:13 ` Bernhard Reutner-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7af7c9b-f787-83c7-d1d4-d0ba4bd05035@orange.fr \
--to=morin-mikael@orange.fr \
--cc=aldot@gcc.gnu.org \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).