From: Tobias Burnus <tobias@codesourcery.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>,
Paul Richard Thomas <paul.richard.thomas@gmail.com>
Subject: *PING* — Re: Fortran: Create CLASS(*) early to avoid ICE [PR99254]
Date: Wed, 3 Mar 2021 12:47:48 +0100 [thread overview]
Message-ID: <e72d662a-1bff-e888-c7a4-8e5f9b38e795@codesourcery.com> (raw)
In-Reply-To: <b2a64ecf-4354-c6b2-5837-c60bad74de05@codesourcery.com>
*PING*
I think the patch is an improvement, even though there is a small
regression and many issues are not covered: PR fortran/99266 and as
explained below.
On 25.02.21 12:16, Tobias Burnus wrote:
> The issue is that for CLASS – and in particular CLASS(*)
> the ts.u.derived->components is not yet created when it is
> accessed. – PR99138 shows a similar case (unfixed!
> See comment 5 and initial report for two examples).
>
> There is an issue for code like:
> class(*) var
> dimension :: var(..)
> that the attribute is not properly encoded in the class.
> That's independent of this patch, cf. PR fortran/99266.
>
> NOTE: This patch causes a regression:
> subroutine foo()
> class(*) :: x
> allocatable :: x
> is now rejected with:
> CLASS variable ‘x’ at (1) must be dummy, allocatable or pointer
>
> HOWEVER: While that was accepted before,
> subroutine foo(dummy)
> class(*) :: dummy
> allocatable :: dummy
> failed before and still fails. (→ class_ok handling in
> gfc_build_class_symbol).
>
> All those issues are tracked in that PR fortran/99266.
>
> OK for the trunk? What about GCC 10??
>
> I am unsure about GCC 10 due to the new regression;
> the issue (PR99254) was reported as new ICE between
> 20190825 and 20190901.
>
> Tobias
>
> PS: I still do not like the way we represent CLASS internally,
> but I think I had complained about this already years ago...
> Can proponents of the current way please look at
> PR fortran/99266 ?
>
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
next prev parent reply other threads:[~2021-03-03 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 11:16 Tobias Burnus
2021-03-03 11:47 ` Tobias Burnus [this message]
2021-03-07 17:34 *PING* — " dhumieres.dominique
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e72d662a-1bff-e888-c7a4-8e5f9b38e795@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=paul.richard.thomas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).