public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <tobias@codesourcery.com>
To: Thomas Koenig <tkoenig@netcologne.de>,
	"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] Fix PR 99345, ICE with DO loop checking
Date: Mon, 15 Mar 2021 09:27:12 +0100	[thread overview]
Message-ID: <f4b6ed05-219a-33b6-8224-8434791e33cf@codesourcery.com> (raw)
In-Reply-To: <70f57767-1529-fb28-ec49-0d75fbc31197@netcologne.de>

Hello Thomas, hello World,

On 14.03.21 21:18, Thomas Koenig via Fortran wrote:
> the attached, rather obvious patch fixes an ICE on valid which
> came about because I did not handle EXEC_IOLENGTH as start of
> an I/O statement when checking for the DO loop variable.
> This is an 11 regression.
>
> Thanks to Harald for reducing this down to the bare
> minimum.
>
> Regression-tested on x86_64-pc-linux-gnu.
> OK for trunk?

OK. Thanks for the patch and thanks to Martin & Harald for the test-case
reduction and for Mathias "doko" for the reporting!

Tobias

> Handle EXEC_IOLENGTH in doloop_contained_procedure_code.
>
> gcc/fortran/ChangeLog:
>
>         PR fortran/99345
>         * frontend-passes.c (doloop_contained_procedure_code):
>         Properly handle EXEC_IOLENGTH.
>
> gcc/testsuite/ChangeLog:
>
>         PR fortran/99345
>         * gfortran.dg/do_check_16.f90: New test.
>         * gfortran.dg/do_check_17.f90: New test.
>
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf

      reply	other threads:[~2021-03-15  8:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-14 20:18 Thomas Koenig
2021-03-15  8:27 ` Tobias Burnus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4b6ed05-219a-33b6-8224-8434791e33cf@codesourcery.com \
    --to=tobias@codesourcery.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tkoenig@netcologne.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).