From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: detect blanks within literal constants in free-form mode [PR92805]
Date: Fri, 29 Jul 2022 13:11:33 +0200 [thread overview]
Message-ID: <fbc69384-d5db-6a37-9ee0-477e61cf3933@orange.fr> (raw)
In-Reply-To: <trinity-182352dd-523c-42bc-a3d1-17d9b69c0432-1659039117168@3c-app-gmx-bap60>
Hello,
Le 28/07/2022 à 22:11, Harald Anlauf via Fortran a écrit :
> Dear all,
>
> in free-form mode, blanks are significant, so they cannot appear
> in literal constants, especially not before or after the "_" that
> separates the literal and the kind specifier.
>
> The initial patch from Steve addressed numerical literals, which
> I completed by adjusting the parsing of string literals.
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
>
It looks correct, but I think we should continue to have the free vs
fixed form abstracted away from the parsing code.
So, I suggest instead to remove the calls to gfc_gobble_whitespace in
match_string_constant, and use gfc_next_char instead of gfc_match_char
in get_kind.
Mikael
next prev parent reply other threads:[~2022-07-29 11:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 20:11 Harald Anlauf
2022-07-29 11:11 ` Mikael Morin [this message]
2022-07-29 19:59 ` [PATCH, v2] " Harald Anlauf
2022-07-29 19:59 ` Harald Anlauf
2022-07-29 20:36 ` Mikael Morin
2022-07-29 21:09 ` [PATCH, v3] " Harald Anlauf
2022-07-29 21:09 ` Harald Anlauf
2022-07-30 7:46 ` Thomas Koenig
2022-07-30 18:32 ` Harald Anlauf
2022-07-30 18:32 ` Harald Anlauf
2022-07-30 8:28 ` Mikael Morin
2022-07-30 19:40 ` [PATCH, v4] " Harald Anlauf
2022-07-31 8:35 ` Mikael Morin
2022-07-31 19:01 ` Harald Anlauf
2022-07-31 19:01 ` Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbc69384-d5db-6a37-9ee0-477e61cf3933@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).