public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: Thomas Koenig <tkoenig@netcologne.de>, fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, v3] Fortran: detect blanks within literal constants in free-form mode [PR92805]
Date: Sat, 30 Jul 2022 20:32:38 +0200	[thread overview]
Message-ID: <d9059a89-8a22-16ee-63e3-2b413eb8c3c1@gmx.de> (raw)
In-Reply-To: <fda1ad07-970a-6f85-d081-8cabf5ef137d@netcologne.de>

Hi Thomas,

Am 30.07.22 um 09:46 schrieb Thomas Koenig via Fortran:
>
> Hi Harald,
>
>> This introduces the helper function gfc_match_next_char, which is
>> your second option.
>
> I would be a little bit concerned about compilation times
> with the additional function call overhead.

the function it replaces (gfc_match_char) is also in a different
file, thus the overhead is at least neutral.  Given that the latter
has an additional call to gfc_gobble_whitespace(), we actually get
better...

> The function is used only in one place; would it make
> sense to put it into primary.cc and declare it static?

Can do that.

> Best regards
>
>      Thomas
>

Thanks,
Harald

WARNING: multiple messages have this Message-ID

From: Harald Anlauf <anlauf@gmx.de>
To: fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, v3] Fortran: detect blanks within literal constants in free-form mode [PR92805]
Date: Sat, 30 Jul 2022 20:32:38 +0200	[thread overview]
Message-ID: <d9059a89-8a22-16ee-63e3-2b413eb8c3c1@gmx.de> (raw)
Message-ID: <20220730183238.v2J_kVe40aOBtOqcxH5zEdO82GS5VqDyp2_CQj-V9Cs@z> (raw)
In-Reply-To: <fda1ad07-970a-6f85-d081-8cabf5ef137d@netcologne.de>

Hi Thomas,

Am 30.07.22 um 09:46 schrieb Thomas Koenig via Fortran:
> 
> Hi Harald,
> 
>> This introduces the helper function gfc_match_next_char, which is
>> your second option.
> 
> I would be a little bit concerned about compilation times
> with the additional function call overhead.

the function it replaces (gfc_match_char) is also in a different
file, thus the overhead is at least neutral.  Given that the latter
has an additional call to gfc_gobble_whitespace(), we actually get
better...

> The function is used only in one place; would it make
> sense to put it into primary.cc and declare it static?

Can do that.

> Best regards
> 
>      Thomas
> 

Thanks,
Harald


  reply	other threads:[~2022-07-30 18:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 20:11 [PATCH] " Harald Anlauf
2022-07-29 11:11 ` Mikael Morin
2022-07-29 19:59   ` [PATCH, v2] " Harald Anlauf
2022-07-29 19:59     ` Harald Anlauf
2022-07-29 20:36     ` Mikael Morin
2022-07-29 21:09       ` [PATCH, v3] " Harald Anlauf
2022-07-29 21:09         ` Harald Anlauf
2022-07-30  7:46         ` Thomas Koenig
2022-07-30 18:32           ` Harald Anlauf [this message]
2022-07-30 18:32             ` Harald Anlauf
2022-07-30  8:28         ` Mikael Morin
2022-07-30 19:40           ` [PATCH, v4] " Harald Anlauf
2022-07-31  8:35             ` Mikael Morin
2022-07-31 19:01               ` Harald Anlauf
2022-07-31 19:01                 ` Harald Anlauf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9059a89-8a22-16ee-63e3-2b413eb8c3c1@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tkoenig@netcologne.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).