* [PATCH, committed] PR fortran/103609 - [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243
@ 2021-12-08 20:21 Harald Anlauf
0 siblings, 0 replies; only message in thread
From: Harald Anlauf @ 2021-12-08 20:21 UTC (permalink / raw)
To: fortran, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
Dear all,
the attached patch fixes a NULL pointer dereference for a missed
declaration of a dummy argument or a conflict of a procedure with
another decl.
Committed as obvious after regtesting on x86_64-pc-linux-gnu:
commit r12-5847-gb77968a70537429b4f548f90c369d26e6b6943cc
Author: Harald Anlauf <anlauf@gmx.de>
Date: Wed Dec 8 21:14:19 2021 +0100
Fortran: avoid NULL pointer dereference on missing or bad dummy arguments
gcc/fortran/ChangeLog:
PR fortran/103609
* symbol.c (gfc_sym_get_dummy_args): Catch NULL pointer
dereference.
gcc/testsuite/ChangeLog:
PR fortran/103609
* gfortran.dg/pr103609.f90: New test.
Thanks,
Harald
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pr103609.diff --]
[-- Type: text/x-patch, Size: 1627 bytes --]
From b77968a70537429b4f548f90c369d26e6b6943cc Mon Sep 17 00:00:00 2001
From: Harald Anlauf <anlauf@gmx.de>
Date: Wed, 8 Dec 2021 21:14:19 +0100
Subject: [PATCH] Fortran: avoid NULL pointer dereference on missing or bad
dummy arguments
gcc/fortran/ChangeLog:
PR fortran/103609
* symbol.c (gfc_sym_get_dummy_args): Catch NULL pointer
dereference.
gcc/testsuite/ChangeLog:
PR fortran/103609
* gfortran.dg/pr103609.f90: New test.
---
gcc/fortran/symbol.c | 3 +++
gcc/testsuite/gfortran.dg/pr103609.f90 | 15 +++++++++++++++
2 files changed, 18 insertions(+)
create mode 100644 gcc/testsuite/gfortran.dg/pr103609.f90
diff --git a/gcc/fortran/symbol.c b/gcc/fortran/symbol.c
index 179f6029ca3..ebd99846610 100644
--- a/gcc/fortran/symbol.c
+++ b/gcc/fortran/symbol.c
@@ -5240,6 +5240,9 @@ gfc_sym_get_dummy_args (gfc_symbol *sym)
{
gfc_formal_arglist *dummies;
+ if (sym == NULL)
+ return NULL;
+
dummies = sym->formal;
if (dummies == NULL && sym->ts.interface != NULL)
dummies = sym->ts.interface->formal;
diff --git a/gcc/testsuite/gfortran.dg/pr103609.f90 b/gcc/testsuite/gfortran.dg/pr103609.f90
new file mode 100644
index 00000000000..57f6a3b1531
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr103609.f90
@@ -0,0 +1,15 @@
+! { dg-do compile }
+! PR fortran/103609 - ICE in gfc_sym_get_dummy_args
+! Contributed by G.Steinmetz
+
+program p
+ implicit none
+ integer :: i
+ do i = 1, 2
+ call s
+ end do
+contains
+ subroutine s
+ call sub(x) ! { dg-error "has no IMPLICIT type" }
+ end
+end
--
2.26.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-12-08 20:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08 20:21 [PATCH, committed] PR fortran/103609 - [11/12 Regression] ICE in gfc_sym_get_dummy_args, at fortran/symbol.c:5243 Harald Anlauf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).