From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 6/8] fortran: use grep -F instead of fgrep
Date: Fri, 24 Jun 2022 14:35:20 +0200 [thread overview]
Message-ID: <ydd35fufddj.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <09114af24f7f09eb2fa6c7dc743de18480d8bd7d.camel@xry111.site> (Xi Ruoyao's message of "Fri, 24 Jun 2022 20:22:42 +0800")
Hi Xi,
> On Fri, 2022-06-24 at 13:13 +0200, Bernhard Reutner-Fischer wrote:
>
>> > - if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v
>> > -i debian' >/dev/null 2>&1; then \
>> > + if $(SHELL) -c 'install-info --version | sed 1q | grep -F -s -v
>> > -i debian' >/dev/null 2>&1; then \
>> > echo " install-info --delete --info-dir=$(DESTDIR)$(infodir)
>> > $(DESTDIR)$(infodir)/gfortran.info"; \
>> > install-info --delete --info-dir=$(DESTDIR)$(infodir)
>> > $(DESTDIR)$(infodir)/gfortran.info || : ; \
>> > else : ; fi; \
>>
>> I'd replace -s >/dev/null 2>&1 with -q while at it.
>>
>> But why is -F used here in the first place?
>> I do not see much in debian that can be interpreted as a regex?
>
> I'm not sure. It was there since 2004. Perhaps the author thinks fgrep
> may save several CPU cycles :). I'll just use a plain grep in PATCH v2.
>
> Rainer: do you have some idea about the availability of "-q" on
> different hosts? If you agree I'll use it instead of -s > /dev/null
> too.
again, the autoconf manual warns agains it, even more so against -s.
That's the first reference for portability issues and shouldn't be
ignored without good reason.
In the GCC and Solaris context, /bin/grep supports both -q and -s in
Solaris 11.3 and 11.4. It doesn't support -q on Solaris 10, though
(again, no longer relevant for GCC).
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2022-06-24 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <74ea0c62ebe19db186263053e4051f81d46e9da4.camel@xry111.site>
[not found] ` <3fe5664607c4e530fbb91048c2e363ddee917250.camel@xry111.site>
2022-06-24 11:13 ` Bernhard Reutner-Fischer
2022-06-24 12:22 ` Xi Ruoyao
2022-06-24 12:35 ` Rainer Orth [this message]
2022-06-24 18:30 ` Bernhard Reutner-Fischer
2022-06-24 13:58 ` Thomas Koenig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd35fufddj.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).