From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Xi Ruoyao via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: rep.dot.nop@gmail.com, Xi Ruoyao <xry111@xry111.site>,
fortran@gcc.gnu.org
Subject: Re: [PATCH 6/8] fortran: use grep -F instead of fgrep
Date: Fri, 24 Jun 2022 13:13:31 +0200 [thread overview]
Message-ID: <20220624131331.0b157480@nbbrfq> (raw)
In-Reply-To: <3fe5664607c4e530fbb91048c2e363ddee917250.camel@xry111.site>
On Fri, 24 Jun 2022 15:06:32 +0800
Xi Ruoyao via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> fgrep has been deprecated in favor of grep -F for a long time, and the
> next grep release (3.8 or 4.0) will print a warning of fgrep is used.
> Stop using fgrep so we won't see the warning.
>
> gcc/ChangeLog:
>
> * fortran/Make-lang.in: Use grep -F instead of fgrep.
> ---
> gcc/fortran/Make-lang.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/fortran/Make-lang.in b/gcc/fortran/Make-lang.in
> index 1cb47cb1a52..51279b03aad 100644
> --- a/gcc/fortran/Make-lang.in
> +++ b/gcc/fortran/Make-lang.in
> @@ -278,7 +278,7 @@ $(DESTDIR)$(man1dir)/$(GFORTRAN_INSTALL_NAME)$(man1ext): doc/gfortran.1 \
> -chmod a-x $@
>
> fortran.uninstall:
> - if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i debian' >/dev/null 2>&1; then \
> + if $(SHELL) -c 'install-info --version | sed 1q | grep -F -s -v -i debian' >/dev/null 2>&1; then \
> echo " install-info --delete --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/gfortran.info"; \
> install-info --delete --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/gfortran.info || : ; \
> else : ; fi; \
I'd replace -s >/dev/null 2>&1 with -q while at it.
But why is -F used here in the first place?
I do not see much in debian that can be interpreted as a regex?
thanks,
next parent reply other threads:[~2022-06-24 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <74ea0c62ebe19db186263053e4051f81d46e9da4.camel@xry111.site>
[not found] ` <3fe5664607c4e530fbb91048c2e363ddee917250.camel@xry111.site>
2022-06-24 11:13 ` Bernhard Reutner-Fischer [this message]
2022-06-24 12:22 ` Xi Ruoyao
2022-06-24 12:35 ` Rainer Orth
2022-06-24 18:30 ` Bernhard Reutner-Fischer
2022-06-24 13:58 ` Thomas Koenig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624131331.0b157480@nbbrfq \
--to=rep.dot.nop@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).