public inbox for frysk-bugzilla@sourceware.org
help / color / mirror / Atom feed
From: "npremji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: frysk-bugzilla@sourceware.org
Subject: [Bug general/3873] New: TestLib.isChildOf() to use Stat.ppid rather than proc.getParent().getPid()
Date: Mon, 15 Jan 2007 19:52:00 -0000	[thread overview]
Message-ID: <20070115195220.3873.npremji@redhat.com> (raw)

Trying to switch over isChildOf to use Stat.ppid rather than using
proc.getParent().getPid() so that getProc interface can be used (an even more
optimized interface than findProc).

The problem is some testcases have problems with this new implementation as
sometimes the ppid returned from Stat is 0. I think this means that the process
is a zombie but I'm not sure. The Stat.state character returns ^@ instead of 'Z'.

Code:
    static public boolean isChildOf (int pid, Proc proc)
    {
      logger.log(Level.FINE, "isChildOf pid: {0} proc: {1}\n", 
                 new Object[] {new Integer(pid), proc});
	// Process 1 has no parent so can't be a child of mine.
	if (proc.getPid () == 1)
      {
        logger.log(Level.FINE, "isChildOf proc is init\n");
	    return false;
      }
	// If the parent's pid matches this processes pid, assume that
	// is sufficient.  Would need a very very long running system
	// for that to not be the case.        
    
    Stat stat = new Stat();
    stat.refresh(proc.id.id);
    
	if (stat.ppid == pid)
      {
        logger.log(Level.FINE, "isChildOf proc is child\n");
	    return true;
      }
    logger.log(Level.FINE, "isChildOf proc {3} not child pid: {0} ppid: {1}
parent: {2}\n",
               new Object[] {new Integer(pid), new Integer(stat.ppid),
proc.getParent(), proc});
    
    logger.log(Level.FINE, "isChildOf status{0}\n", new Character(stat.state));
	return false;
    }

Log to follow.

-- 
           Summary: TestLib.isChildOf() to use Stat.ppid rather than
                    proc.getParent().getPid()
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: npremji at redhat dot com
OtherBugsDependingO 3539
             nThis:


http://sourceware.org/bugzilla/show_bug.cgi?id=3873

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


             reply	other threads:[~2007-01-15 19:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15 19:52 npremji at redhat dot com [this message]
2007-01-15 19:54 ` [Bug general/3873] " npremji at redhat dot com
2007-01-15 20:45 ` npremji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070115195220.3873.npremji@redhat.com \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=frysk-bugzilla@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).