[Bug general/3928] New: Pty.cxx frysk::sys::Pty::setUpPtyForConsole uses system() calls to set tty properties

[Bug general/3928] New: Pty.cxx frysk::sys::Pty::setUpPtyForConsole uses system() calls to set tty properties

[pmuldoon at redhat dot com]

This might call problems with SIGCHLD and Frysk. Code snippet below.

        char prefix[30] = "stty -F ";
        char *pts_name = ptsname(master);
        char cmd[60];
         
        if (pts_name != NULL)
        {
                strcat(prefix, pts_name);
                strcpy(cmd, prefix);
                strcat(cmd, " -icanon min 1");
                system(cmd);
    
                strcpy(cmd, prefix);
                strcat(cmd, " -echo");
                system(cmd);
        }

-- 
           Summary: Pty.cxx frysk::sys::Pty::setUpPtyForConsole uses
                    system()  calls to set tty properties
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: pmuldoon at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=3928

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/3928] Pty.cxx frysk::sys::Pty::setUpPtyForConsole uses system() calls to set tty properties

[cmoller at redhat dot com]

------- Additional Comments From cmoller at redhat dot com  2007-01-26 19:42 -------
What the system() stuff below is doing is setting the way the tty works.  It
could be done w/o system() by using terminal control ops similar to the following:

{
  struct termios tio;

  if (0 > tcgetattr(fd, *tio)) return -1;

  tio.c_lflag |= ICANON | ECHO;
  tio.c_cc[VMIN] = 1;

  if (0 < tcsetattr(fd, TCSANOW, ,&tio)) return -1;

  return 0;
}

where fd is the file descriptor associated with pts_name.

There are a few other wrinkles that might be relevant, but they'd depend on what
else is going on.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3928

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/3928] Pty.cxx frysk::sys::Pty::setUpPtyForConsole uses system() calls to set tty properties

[cagney at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|frysk-bugzilla at sourceware|cagney at redhat dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=3928

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.