[Bug general/4390] New: CorefileByteBuffer needs to use a lighter weight file access method than RandomAccessFile

[Bug general/4390] New: CorefileByteBuffer needs to use a lighter weight file access method than RandomAccessFile

[pmuldoon at redhat dot com]

A read from a corefile should be open->read->close. Doing this with
RandomAccessFile would cause many dozens of java objects queued for GC on a lot
of peek() operations. Right now, because of that, CorefileBytebuffer maintains
the RandomAccessFile open for the life of the buffer, consuming one FD for a
long time.

A very light weight object that keeps the file closed, opens it on read, then
closes it again is required, so that fd's and other systems resources can be
cycled back into the pool

-- 
           Summary: CorefileByteBuffer needs to use a lighter weight file
                    access method than RandomAccessFile
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: pmuldoon at redhat dot com
OtherBugsDependingO 4378
             nThis:


http://sourceware.org/bugzilla/show_bug.cgi?id=4390

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4390] CorefileByteBuffer needs to use a lighter weight file access method than RandomAccessFile

[pmuldoon at redhat dot com]

------- Additional Comments From pmuldoon at redhat dot com  2008-01-09 13:43 -------
Appears that the comment above fixed the issue, and this bug was left open

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=4390

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4390] CorefileByteBuffer needs to use a lighter weight file access method than RandomAccessFile

[pmuldoon at redhat dot com]

------- Additional Comments From pmuldoon at redhat dot com  2008-01-09 13:47 -------
Reopening to add actual commit changelog

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sourceware.org/bugzilla/show_bug.cgi?id=4390

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4390] CorefileByteBuffer needs to use a lighter weight file access method than RandomAccessFile

[pmuldoon at redhat dot com]

------- Additional Comments From pmuldoon at redhat dot com  2008-01-09 13:47 -------
Changing Assigned to pmuldoon

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sourceware.org/bugzilla/show_bug.cgi?id=4390

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4390] CorefileByteBuffer needs to use a lighter weight file access method than RandomAccessFile

[pmuldoon at redhat dot com]

------- Additional Comments From pmuldoon at redhat dot com  2008-01-09 13:47 -------
2007-05-22  Phil Muldoon  <pmuldoon@redhat.com>

	* CorefileByteBuffer.java (finalize): Remove.
	(isFileOpen): Remove.
	(peek): Rewrite to use StatelessFile.
	(isFileSane): Test for object creation.
	(openFile): Rewrite. Use StatlessFile.
	(CorefileByteBuffer): Switch order of file open
	and elf address offset table creation.
	* TestCorefileByteBuffer (testCoreFileByteBufferMapOverrun): Move
	overrun location.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=4390

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4390] CorefileByteBuffer needs to use a lighter weight file access method than RandomAccessFile

[pmuldoon at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|frysk-bugzilla at sourceware|pmuldoon at redhat dot com
                   |dot org                     |
             Status|REOPENED                    |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=4390

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.