[Bug general/4668] New: fstep misses first few instructions

[Bug general/4668] New: fstep misses first few instructions

[mark at klomp dot org]

fstep inserts an instruction observer in updateAttached() but doesn't BLOCK and
wait till the instruction observer is installed. This makes fstep miss the first
few instructions of the process.

This might actually be a bug in how instruction observers are installed in the
attaching states, not directly in fstep. It is reasonable fstep to assume that
in instruction observer is installed immediately instead of being queued in this
case.

See also the related bug #4663.

-- 
           Summary: fstep misses first few instructions
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: mark at klomp dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=4668

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4668] fstep misses first few instructions

[cagney at redhat dot com]

------- Additional Comments From cagney at redhat dot com  2007-06-20 16:49 -------
fstep needs to keep the task blocked using the attach observer until it as
received an ack confirming that the instruction observer has been added; making
it consistent with mcvet's testcase.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |4663


http://sourceware.org/bugzilla/show_bug.cgi?id=4668

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4668] fstep misses first few instructions

[mark at klomp dot org]

------- Additional Comments From mark at klomp dot org  2007-07-09 16:34 -------
Fixed by:

frysk-core/frysk/bindir/ChangeLog
2007-07-09  Mark Wielaard  <mwielaard@redhat.com>

    Fixes bug #4668
    * fstep.java: Implement TaskObserver.Code.
    (updateAttached): Depending on whether or not the user supplied a
    command line to execute or a pid to trace either put a breakpoint
    on the first real instruction or start tracing immediately. Return
    Action.BLOCK.
    (updateHit): New method.
    (addedTo): Unblock task.
    * TestFStep.java: New test.

frysk-core/frysk/proc/live/ChangeLog
2007-07-09  Mark Wielaard  <mwielaard@redhat.com>

    * LinuxTaskState.java (wantToAttachContinue): Add
    handleAddObservation() and handleUnblock().


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=4668

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4668] fstep misses first few instructions

[mark at klomp dot org]

-- 
Bug 4668 depends on bug 4663, which changed state.

Bug 4663 Summary: TaskObserver.Instruction doesn't appear to unblock on new process' first instructions
http://sourceware.org/bugzilla/show_bug.cgi?id=4663

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

http://sourceware.org/bugzilla/show_bug.cgi?id=4668

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.