[Bug general/4730] New: testLeakyFileDescriptors() in TestFileDescriptor trips up junit

[Bug general/4730] New: testLeakyFileDescriptors() in TestFileDescriptor trips up junit

[kris dot van dot hees at oracle dot com]

The testLeakyFileDescriptors() method in TestFileDescriptor executes a loop
creating 4000 fds, followed by a loop to close any file descriptors that are
still in existence afterwards (i.e. any that were not garbage collected).

Problem is that the creation of fds is not catching any exceptions that are
being thrown by the instantiation of new FileDescriptor objects, thereby
resulting in the later code (cleaning up non-garbage collected fds) never being
executed.

Problems with this:

1) The test never actually tests anything against a PASS/FAIL criterium.
   Instead, it either passes or its execution is considered an error.  That
   is obviously wrong because tests by their very nature should be defined as
   testing a PASS/FAIL condition.
2) The test doesn't handle an exception occurring in the lower level code, even
   though such an exception is not a reflection of a buggy test but rather of
   a failure criterium being triggered.

-- 
           Summary: testLeakyFileDescriptors() in TestFileDescriptor trips
                    up junit
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: kris dot van dot hees at oracle dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=4730

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.