public inbox for frysk-bugzilla@sourceware.org
help / color / mirror / Atom feed
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: frysk-bugzilla@sourceware.org
Subject: [Bug general/4852] New: Never use Proc.getExe() except for display (possible) executable path
Date: Fri, 27 Jul 2007 09:38:00 -0000	[thread overview]
Message-ID: <20070727093818.4852.mark@klomp.org> (raw)

Proc.getExe() returns a path to the (possibly incorrect) of the executable being
examined. Since it isn't guaranteed to be correct it should never be used for
anything except for informational messages. Since it is often correct it is used
in places in frysk-core to get at the executable, this is not correct though
(for example when examining a core file it is not the executable you are
interested in, but the data/text/code collected by the CoreFile reader). In
particular these files should be examined and changed that create Elf objects
directly from the Proc.getExe() result:

frysk-core/frysk/debuginfo/DebugInfo.java
frysk-core/frysk/proc/TestTaskObserverCode.java
frysk-core/frysk/proc/dead/TestLinuxCore.java

frysk-core/frysk/dom/DOMImage.java uses getExe() to get at the include paths for
the source.

frysk-core/frysk/proc/IsaFactory.java getIsa() reads /proc/pid/exe directly.

frysk-gui also uses getExe() repeatably, but probably correctly, these should be
checked though:

frysk-gui/frysk/gui/sessions/WatchList.java
frysk-gui/frysk/gui/monitor/GuiProc.java
frysk-gui/frysk/gui/monitor/PickProcListView.java
frysk-gui/frysk/gui/monitor/PickProcsListView.java
frysk-gui/frysk/gui/monitor/filters/ProcPathFilter.java
frysk-gui/frysk/gui/monitor/PickProcDialog.java
frysk-gui/frysk/gui/srcwin/SourceWindow.java

-- 
           Summary: Never use Proc.getExe() except for display (possible)
                    executable path
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: mark at klomp dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=4852

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


                 reply	other threads:[~2007-07-27  9:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070727093818.4852.mark@klomp.org \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=frysk-bugzilla@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).