[Bug general/4894] New: "java.lang.RuntimeException: not added" when removing codeObserver inside its own handler

[Bug general/4894] New: "java.lang.RuntimeException: not added" when removing codeObserver inside its own handler

[pmachata at redhat dot com]

FC6

The exception I'm getting is the following:
java.lang.RuntimeException: not added
   at frysk.proc.live.LinuxProcState$3.handleDeleteObservation(fltrace)
   at frysk.proc.Proc$13.execute(fltrace)
   at frysk.event.EventLoop.runEventLoop(fltrace)
   at frysk.event.EventLoop.run(fltrace)
   at frysk.util.Ltrace.trace(fltrace)
   at frysk.bindir.fltrace.run(fltrace)
   at frysk.bindir.fltrace.main(fltrace)

This happens when I have the following code in updateHit:
    public Action updateHit (Task task, long addr)
    {
      task.requestDeleteCodeObserver(this, addr);
      task.requestUnblock(this);
      return Action.BLOCK;
    }

I created a test case, will commit that.

-- 
           Summary: "java.lang.RuntimeException: not added" when removing
                    codeObserver inside its own handler
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: pmachata at redhat dot com
  GCC host triplet: i686-pc-linux-gnu
OtherBugsDependingO 2229
             nThis:


http://sourceware.org/bugzilla/show_bug.cgi?id=4894

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4894] "java.lang.RuntimeException: not added" when removing codeObserver inside its own handler

[pmachata at redhat dot com]

------- Additional Comments From pmachata at redhat dot com  2007-08-03 23:34 -------
The test is testCodeRemovedInHit(frysk.proc.TestTaskObserverCode).

Btw, addFailed gets called even for failed delete request.  It's a bit confusing.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4894

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4894] "java.lang.RuntimeException: not added" when removing codeObserver inside its own handler

[mark at klomp dot org]

------- Additional Comments From mark at klomp dot org  2007-08-06 13:18 -------
Thanks for the testcase. Code observers can be added multiple times for
different addresses (as you do in this test case). But Proc doesn't know about
this and treats the double add and one delete as if the Code observer should be
deleted completely, so if you delete it for the other address the Proc sanity
check kicks in and flags it as a double delete.

Quick workaround for now is to create different Code observers for different
addresses.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4894

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4894] "java.lang.RuntimeException: not added" when removing codeObserver inside its own handler

[mark at klomp dot org]

------- Additional Comments From mark at klomp dot org  2007-08-06 14:44 -------
2007-08-06  Mark Wielaard  <mark@klomp.org>

    Fixes bug #4894
    * Proc.java (observations): Turn into a Collection that can
    contain an observer multiple times.
    * TestTaskObserverCode.java (testCodeRemovedInHit): Explicitly
    wait for add and delete.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=4894

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.