public inbox for frysk-bugzilla@sourceware.org help / color / mirror / Atom feed
From: "cagney at redhat dot com" <sourceware-bugzilla@sourceware.org> To: frysk-bugzilla@sourceware.org Subject: [Bug general/4993] New: tab-complete uses dies not expression's type Date: Thu, 06 Sep 2007 01:37:00 -0000 [thread overview] Message-ID: <20070906013711.4993.cagney@redhat.com> (raw) The tab-completion code, in DebugInfo looks like: sInput += (char)3; CppLexer lexer = new CppLexer(new StringReader(sInput)); CppParser parser = new CppParser(lexer); try { parser.start(); } catch (antlr.RecognitionException ignore) { // FIXME: Why is this ignored? } catch (antlr.TokenStreamException ignore) { // FIXME: Why is this ignored? } catch (frysk.expr.TabException t) { token = t.getTabExpression().trim(); } TabException should be capturing two things: the final token that possibly contains the tab; the successfully parsed sub expression leading into the tab. For instance, given <<a()[0].<TAB>>>, it would have both the parse tree for <<a()[0].>> and the token <tab>; and given <<a()[0].b<TAB>>> it would get <<a()[0].>> and b<TAB>. This code can then perform the two operations: - walk the sub-expression tree to determine the result type - use the result type to determine how to complete the final token it is instead doing the following: DwarfDie[] allDies = die.getScopes(pc - bias.bias); List candidates_p = die.getScopeVarNames(allDies, token); boolean haveStruct = false; if (token.endsWith(".")) haveStruct = true; for (Iterator i = candidates_p.iterator(); i.hasNext();) { String sNext = (haveStruct ? "." : "") + (String) i.next(); candidates.add(sNext); } which can't handle more complex cases. -- Summary: tab-complete uses dies not expression's type Product: frysk Version: unspecified Status: NEW Severity: normal Priority: P2 Component: general AssignedTo: frysk-bugzilla at sourceware dot org ReportedBy: cagney at redhat dot com CC: scox at redhat dot com http://sourceware.org/bugzilla/show_bug.cgi?id=4993 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
reply other threads:[~2007-09-06 1:37 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070906013711.4993.cagney@redhat.com \ --to=sourceware-bugzilla@sourceware.org \ --cc=frysk-bugzilla@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).