[Bug general/4993] New: tab-complete uses dies not expression's type

[Bug general/4993] New: tab-complete uses dies not expression's type

[cagney at redhat dot com]

The tab-completion code, in DebugInfo looks like:

	sInput += (char)3;
	CppLexer lexer = new CppLexer(new StringReader(sInput));
	CppParser parser = new CppParser(lexer);
	try {
	    parser.start();
	} catch (antlr.RecognitionException ignore) {
	    // FIXME: Why is this ignored?
	} catch (antlr.TokenStreamException ignore) {
	    // FIXME: Why is this ignored?
	} catch (frysk.expr.TabException t) {
	    token = t.getTabExpression().trim();
	}

TabException should be capturing two things: the final token that possibly
contains the tab; the successfully parsed sub expression leading into the tab. 
For instance, given <<a()[0].<TAB>>>, it would have both the parse tree for
<<a()[0].>> and the token <tab>; and given <<a()[0].b<TAB>>> it would get
<<a()[0].>> and b<TAB>.

This code can then perform the two operations:
   - walk the sub-expression tree to determine the result type
   - use the result type to determine how to complete the final token
it is instead doing the following:

	DwarfDie[] allDies = die.getScopes(pc - bias.bias);
	List candidates_p = die.getScopeVarNames(allDies, token);
	boolean haveStruct = false;
	if (token.endsWith("."))
	    haveStruct = true;
	for (Iterator i = candidates_p.iterator(); i.hasNext();) {
            String sNext = (haveStruct ? "." : "") + (String) i.next();
            candidates.add(sNext);
        }

which can't handle more complex cases.

-- 
           Summary: tab-complete uses dies not expression's type
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: cagney at redhat dot com
                CC: scox at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=4993

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.