public inbox for frysk-bugzilla@sourceware.org
help / color / mirror / Atom feed
* [Bug general/5234] New: code observers should get updateHit only when observing task really hits the address
@ 2007-10-30 19:33 pmachata at redhat dot com
2007-10-30 22:57 ` [Bug general/5234] code observers gets updateHit several times when observing task " pmachata at redhat dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: pmachata at redhat dot com @ 2007-10-30 19:33 UTC (permalink / raw)
To: frysk-bugzilla
When you register one (observer, address) combination to several tasks, the
observer gets one updateHit for each registration when any of the tasks hits the
breakpoint.
--
Summary: code observers should get updateHit only when observing
task really hits the address
Product: frysk
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: general
AssignedTo: frysk-bugzilla at sourceware dot org
ReportedBy: pmachata at redhat dot com
GCC build triplet: i686-redhat-linux-gnu
GCC host triplet: i686-redhat-linux-gnu
GCC target triplet: i686-redhat-linux-gnu
OtherBugsDependingO 2229
nThis:
http://sourceware.org/bugzilla/show_bug.cgi?id=5234
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug general/5234] code observers gets updateHit several times when observing task hits the address
2007-10-30 19:33 [Bug general/5234] New: code observers should get updateHit only when observing task really hits the address pmachata at redhat dot com
@ 2007-10-30 22:57 ` pmachata at redhat dot com
2007-10-30 23:21 ` pmachata at redhat dot com
2008-04-21 10:29 ` mark at klomp dot org
2 siblings, 0 replies; 4+ messages in thread
From: pmachata at redhat dot com @ 2007-10-30 22:57 UTC (permalink / raw)
To: frysk-bugzilla
------- Additional Comments From pmachata at redhat dot com 2007-10-30 22:57 -------
Clarification. The updateHit is really called several times, with the same
combination of task and address. This ltrace output snippet exhibits the problem:
[22688] call thr->printf(3215026272, 0, 0, 0)\
[22688] call thr->printf(3215026272, 0, 0, 0)\
[22688] call thr->printf(3215026272, 0, 0, 0)\
[22688] call thr->printf(3215026272, 0, 0, 0)\
[22688] call thr->printf(3215026272, 0, 0, 0)\
[22688] call thr->printf(3215026272, 0, 0, 0)
[22688] syscall write(4, 4
, 3086082048)4
[22688] syscall leave write = 2
[22688] leave printf = 2
[22688] leave printf = 2
[22688] leave printf = 2
[22688] leave printf = 2
[22688] leave printf = 2
--
What |Removed |Added
----------------------------------------------------------------------------
Summary|code observers should get |code observers gets
|updateHit only when |updateHit several times when
|observing task really hits |observing task hits the
|the address |address
http://sourceware.org/bugzilla/show_bug.cgi?id=5234
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug general/5234] code observers gets updateHit several times when observing task hits the address
2007-10-30 19:33 [Bug general/5234] New: code observers should get updateHit only when observing task really hits the address pmachata at redhat dot com
2007-10-30 22:57 ` [Bug general/5234] code observers gets updateHit several times when observing task " pmachata at redhat dot com
@ 2007-10-30 23:21 ` pmachata at redhat dot com
2008-04-21 10:29 ` mark at klomp dot org
2 siblings, 0 replies; 4+ messages in thread
From: pmachata at redhat dot com @ 2007-10-30 23:21 UTC (permalink / raw)
To: frysk-bugzilla
------- Additional Comments From pmachata at redhat dot com 2007-10-30 23:21 -------
I added a testcase, testMultiTaskUpdateCalledSeveralTimes.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=5234
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug general/5234] code observers gets updateHit several times when observing task hits the address
2007-10-30 19:33 [Bug general/5234] New: code observers should get updateHit only when observing task really hits the address pmachata at redhat dot com
2007-10-30 22:57 ` [Bug general/5234] code observers gets updateHit several times when observing task " pmachata at redhat dot com
2007-10-30 23:21 ` pmachata at redhat dot com
@ 2008-04-21 10:29 ` mark at klomp dot org
2 siblings, 0 replies; 4+ messages in thread
From: mark at klomp dot org @ 2008-04-21 10:29 UTC (permalink / raw)
To: frysk-bugzilla
------- Additional Comments From mark at klomp dot org 2008-04-21 10:28 -------
commit c9b6156e7b4d4ab4ccb29024e22625901595c15b
Author: Mark Wielaard <mwielaard@redhat.com>
Date: Mon Apr 21 12:24:08 2008 +0200
Record Task registering TaskObserver.Code with BreakpointAddresses. Bug #5234.
frysk-core/frysk/proc/live/ChangeLog
2008-04-21 Mark Wielaard <mwielaard@redhat.com>
* BreakpointAddresses.java: Mark class and methods package private.
(CodeObserver): New final static helper class.
(addBreakpoint): Take CodeObserver as argument, not
TaskObserver.Code.
(removeBreakpoint): Likewise.
(getCodeObservers): Return collection of CodeObservers, not
TaskObserver.Code.
* LinuxPtraceProc.java (BreakpointAction.run): Install or remove
BreakpointAddresses.CodeObserver instead of bare TaskObserver.Code.
* LinuxPtraceTask.java (notifyCodeBreakpoint): Check Task against
BreakpointAddresses.CodeObserver.
* TestTaskObserverCode.java (testMultiTaskUpdateCalledSeveralTimes):
Resolved bug #5234.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=5234
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-21 10:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-30 19:33 [Bug general/5234] New: code observers should get updateHit only when observing task really hits the address pmachata at redhat dot com
2007-10-30 22:57 ` [Bug general/5234] code observers gets updateHit several times when observing task " pmachata at redhat dot com
2007-10-30 23:21 ` pmachata at redhat dot com
2008-04-21 10:29 ` mark at klomp dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).