public inbox for frysk-cvs@sourceware.org
help / color / mirror / Atom feed
* [SCM]  master: 2008-01-18  Phil Muldoon <pmuldoon@redhat.com>
@ 2008-01-18  9:27 pmuldoon
  0 siblings, 0 replies; only message in thread
From: pmuldoon @ 2008-01-18  9:27 UTC (permalink / raw)
  To: frysk-cvs

The branch, master has been updated
       via  ec719f9b7195762e4a4dea29e7b14932b2bfcf6a (commit)
      from  e463ac8102efbc44d7f39c190085ff0522819fd9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email.

- Log -----------------------------------------------------------------
commit ec719f9b7195762e4a4dea29e7b14932b2bfcf6a
Author: Phil Muldoon <pmuldoon@tortura.yyz.redhat.com>
Date:   Thu Jan 17 23:22:05 2008 -0500

    2008-01-18  Phil Muldoon <pmuldoon@redhat.com>
    
            * DwflFactory.java (updateDwfl): Do not overrun map
            length on vdso check.

-----------------------------------------------------------------------

Summary of changes:
 frysk-core/frysk/dwfl/ChangeLog        |    5 +++++
 frysk-core/frysk/dwfl/DwflFactory.java |   14 +++++++++++---
 2 files changed, 16 insertions(+), 3 deletions(-)

First 500 lines of diff:
diff --git a/frysk-core/frysk/dwfl/ChangeLog b/frysk-core/frysk/dwfl/ChangeLog
index 4da4372..37c57c7 100644
--- a/frysk-core/frysk/dwfl/ChangeLog
+++ b/frysk-core/frysk/dwfl/ChangeLog
@@ -1,3 +1,8 @@
+2008-01-18  Phil Muldoon <pmuldoon@redhat.com>
+	
+	* DwflFactory.java (updateDwfl): Do not overrun map
+	length on vdso check.
+
 2008-01-14  Mike Cvet  <mcvet@redhat.com>
 
 	* ElfSectionCache.java: Added.
diff --git a/frysk-core/frysk/dwfl/DwflFactory.java b/frysk-core/frysk/dwfl/DwflFactory.java
index 287a053..8721e2b 100644
--- a/frysk-core/frysk/dwfl/DwflFactory.java
+++ b/frysk-core/frysk/dwfl/DwflFactory.java
@@ -120,9 +120,17 @@ public class DwflFactory
 	// Condensing elf mappings into a single Dwfl_Module per elf image.
 
 	// Base case:
-	// While the map is empty skip.
-	while (! isVDSO(proc, maps[count]) && isEmptyMap(maps[count]))
-	    count++;
+	// While the map is empty skip
+
+	// XXX: Add an explicit if count == maps.length -1 break. What is the 
+	// failure case for not finding a [vdso]?
+        while (! isVDSO(proc, maps[count]) && isEmptyMap(maps[count]))
+        {
+            if (count == (maps.length-1))
+                break;
+            count++;
+        }
+
 	// If map represents the vdso section, report vdso.
 	if (isVDSO(proc, maps[count])) {
 	    logger.log(Level.FINE, "Found the vdso!\n");


hooks/post-receive
--
frysk system monitor/debugger


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-01-18  9:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-18  9:27 [SCM] master: 2008-01-18 Phil Muldoon <pmuldoon@redhat.com> pmuldoon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).