Re: frysk-core/frysk/proc Breakpoint.java ChangeLo ...

Re: frysk-core/frysk/proc Breakpoint.java ChangeLo ...

[Phil Muldoon]

mark@sourceware.org wrote:
> Modified files:
> 	frysk/proc     : Breakpoint.java ChangeLog Isa.java IsaIA32.java 
> 	                 IsaPowerPC.java IsaX8664.java Proc.java 
>
> Log message:
> 	* Proc.java (outOfLineAddresses): New private final field.
> 	(requestedOutOfLineAddresses): New boolean field.
> 	(getOutOfLineAddress): New method.
> 	(doneOutOfLine): Likewise.
>
>   
Mark,

All this new stuff is very exciting. It is awesome to see!

A minor nitpick if you will. I've not really looked at this code in a 
huge amount of detail, so please excuse my nativity here, but can't this 
code go and live in the live/LinuxProc.java implementation instead of 
the abstract Proc.java? The scope rules are package-private so they are 
not public apis? Other than keeping Proc.java as simple as possible, I'm 
not hugely worried.

Regards

Phil

Re: frysk-core/frysk/proc Breakpoint.java ChangeLo ...

[Mark Wielaard]

Hi Phil,

On Wed, 2007-07-04 at 23:21 -0500, Phil Muldoon wrote:
> A minor nitpick if you will. I've not really looked at this code in a 
> huge amount of detail, so please excuse my nativity here, but can't this 
> code go and live in the live/LinuxProc.java implementation instead of 
> the abstract Proc.java? The scope rules are package-private so they are 
> not public apis? Other than keeping Proc.java as simple as possible, I'm 
> not hugely worried.

Yes it can. I have put it on my list to move. But since it is an
implementation detail I want to keep it package private, so some other
consumer classes (Breakpoint and dependencies) need to move with it and
I don't want to make those unnecessary public and break the abstraction.
I'll get to it after some other testing stuff.

Thanks,

Mark