From: Mark Wielaard <mark@klomp.org>
To: frysk@sourceware.org
Subject: Re: frysk-imports frysk/pkglibdir/ChangeLog frysk/ ...
Date: Fri, 26 Oct 2007 15:12:00 -0000 [thread overview]
Message-ID: <1193411543.2931.8.camel@hermans.wildebeest.org> (raw)
In-Reply-To: <20071015180147.24121.qmail@sourceware.org>
Hi Andrew,
On Mon, 2007-10-15 at 18:01 +0000, cagney@sourceware.org wrote:
> 2007-10-15 Andrew Cagney <cagney@redhat.com>
>
> * RegsCase.java (taskObject(Task)): Delete.
> (access(Register,int,int,byte[],int,boolean)): Relace
> accessRegister(Object,Register,int,int,byte[],int,boolean).
> (Value, ByteValue, BigIntegerValue, MaskedValue, SymbolValue)
> (NoValue): New.
> (Values): Replace ValueMap.
> (IA32): Provide values for EIP and maksed EFLAGS.
> * TestRegs.java: Update.
Being able to use a mask for some of the registers is useful. Thanks.
The EFLAGS mask was off by one because the bit values start at zero. The
following makes the test also pass on my machine (Intel x86 T2400).
2007-10-26 Mark Wielaard <mwielaard@redhat.com>
* RegsCase.java (IA32): Don't subtract one from EFLAGS bit mask.
Cheers,
Mark
diff --git a/frysk-core/frysk/testbed/RegsCase.java b/frysk-core/frysk/testbed/R
index c94613d..2078cff 100644
--- a/frysk-core/frysk/testbed/RegsCase.java
+++ b/frysk-core/frysk/testbed/RegsCase.java
@@ -288,7 +288,7 @@ public abstract class RegsCase extends TestLib {
.put(IA32Registers.EBP, // 0xcbfed73c
new byte[] { 0x3c, (byte)0xd7, (byte)0xfe, (byte)0xcb })
.put(IA32Registers.EFLAGS, 0x10246,
- 1 << (21 - 1) // Mask CPUID
+ 1 << 21 // Mask CPUID
)
.put(IA32Registers.ESP, // 0x93d4a6ed
new byte[] { (byte)0xed, (byte)0xa6, (byte)0xd4, (byte)0x93 })
parent reply other threads:[~2007-10-26 15:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20071015180147.24121.qmail@sourceware.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193411543.2931.8.camel@hermans.wildebeest.org \
--to=mark@klomp.org \
--cc=frysk@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).