From: Mark Wielaard <mark@klomp.org>
To: Andrew Cagney <cagney@redhat.com>
Cc: Rick Moseley <rmoseley@redhat.com>, frysk@sourceware.org
Subject: Re: Quick pc hack for exe loading
Date: Tue, 27 Nov 2007 08:25:00 -0000 [thread overview]
Message-ID: <1196151942.3054.5.camel@dijkstra.wildebeest.org> (raw)
In-Reply-To: <474AF9C2.2080607@redhat.com>
Hi Andrew,
On Mon, 2007-11-26 at 11:52 -0500, Andrew Cagney wrote:
> The comment for getRegisterBuffers notes:
>
> protected abstract ByteBuffer[] sendrecRegisterBuffersFIXME();
> /**
> * Return the machine's register banks as an array.
> *
> * XXX: This is being replaced by "getRegisterBanks()" that returns
> * a class that abstracts the ByteArray[] + BankRegister
> * combination.
> */
> public ByteBuffer[] getRegisterBuffersFIXME ()
>
> what prevents the use of getRegisterBanks()?
Right that is the question. Since you introduced the FIXMEs and are
working on this refactoring I assumed that you would fix it when you
were ready and nothing prevented it anymore. Which is the reason I
didn't change it myself.
Cheers,
Mark
next prev parent reply other threads:[~2007-11-27 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 11:35 Mark Wielaard
2007-11-23 17:14 ` Rick Moseley
2007-11-23 17:30 ` Andrew Cagney
2007-11-26 10:40 ` Mark Wielaard
2007-11-26 16:52 ` Andrew Cagney
2007-11-27 8:25 ` Mark Wielaard [this message]
2007-11-27 14:40 ` Andrew Cagney
2007-11-28 9:15 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196151942.3054.5.camel@dijkstra.wildebeest.org \
--to=mark@klomp.org \
--cc=cagney@redhat.com \
--cc=frysk@sourceware.org \
--cc=rmoseley@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).