public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: tromey@redhat.com
Cc: Frysk List <frysk@sourceware.org>
Subject: Re: Patch: bug 5731
Date: Sat, 01 Mar 2008 19:57:00 -0000	[thread overview]
Message-ID: <1204401448.3279.42.camel@localhost.localdomain> (raw)
In-Reply-To: <m3lk52gyrh.fsf@fleche.redhat.com>

Hi Tom,

On Sat, 2008-03-01 at 10:06 -0700, Tom Tromey wrote:
> This fixes bug 5731, which is that the output of plain "set" is ugly.

Thanks. This looks good. I have pushed it.

For this reading along at home. Before this patch:

(fhpd) set
{ERROR_CHECKS=NORMAL, EVENT_INTERRUPT=ON,
EXECUTABLE_PATH=./:/home/mark/bin:/usr/kerberos/bin:/usr/lib/ccache:/usr/local/bin:/usr/bin:/bin:/usr/X11R6/bin, MAX_HISTORY=20, MAX_LEVELS=20, MAX_LIST=20, MAX_PROMPT=40, MODE=MULTILEVEL, PROMPT=(frysk) , SOURCE_PATH=, START_MODEL=ANY, STOP_MODEL=ANY, VERBOSE=WARN}

after:

(fhpd) set
ERROR_CHECKS=NORMAL
EVENT_INTERRUPT=ON
EXECUTABLE_PATH=./:/home/mark/bin:/usr/kerberos/bin:/usr/lib/ccache:/usr/local/bin:/usr/bin:/bin:/usr/X11R6/bin
MAX_HISTORY=20
MAX_LEVELS=20
MAX_LIST=20
MAX_PROMPT=40
MODE=MULTILEVEL
PROMPT=(frysk) 
SOURCE_PATH=
START_MODEL=ANY
STOP_MODEL=ANY
VERBOSE=WARN

> Previously I "washed" the ChangeLog entry when sending a patch.
> I don't know if that is what you want or not.  This time I didn't.

I liked "washed", if only because often the patch for a ChangeLog won't
apply anyway since the top of the file has already changed.

Thanks,

Mark

  reply	other threads:[~2008-03-01 19:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-01 17:56 Tom Tromey
2008-03-01 19:57 ` Mark Wielaard [this message]
2008-03-01 20:35   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204401448.3279.42.camel@localhost.localdomain \
    --to=mark@klomp.org \
    --cc=frysk@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).