From: Tom Tromey <tromey@redhat.com>
To: Frysk List <frysk@sourceware.org>
Subject: Patch: bug 5731
Date: Sat, 01 Mar 2008 17:56:00 -0000 [thread overview]
Message-ID: <m3lk52gyrh.fsf@fleche.redhat.com> (raw)
This fixes bug 5731, which is that the output of plain "set" is ugly.
Previously I "washed" the ChangeLog entry when sending a patch.
I don't know if that is what you want or not. This time I didn't.
Tom
diff --git a/frysk-core/frysk/hpd/ChangeLog b/frysk-core/frysk/hpd/ChangeLog
index 7aba61e..7832a4d 100644
--- a/frysk-core/frysk/hpd/ChangeLog
+++ b/frysk-core/frysk/hpd/ChangeLog
@@ -1,3 +1,10 @@
+2008-03-01 Tom Tromey <tromey@redhat.com>
+
+ Bugzilla 5731
+ * DbgVariableCommands.java (Set.interpret): Use
+ DbgVariables.print.
+ * DbgVariables.java (print): New method.
+
2008-02-29 Tom Tromey <tromey@redhat.com>
* ParameterizedCommand.java (help): Use getWordWrapWriter. Set
diff --git a/frysk-core/frysk/hpd/DbgVariableCommands.java b/frysk-core/frysk/hpd/DbgVariableCommands.java
index f893422..443c21e 100644
--- a/frysk-core/frysk/hpd/DbgVariableCommands.java
+++ b/frysk-core/frysk/hpd/DbgVariableCommands.java
@@ -1,6 +1,6 @@
// This file is part of the program FRYSK.
//
-// Copyright 2005, 2006, 2007 Red Hat Inc.
+// Copyright 2005, 2006, 2007, 2008 Red Hat Inc.
//
// FRYSK is free software; you can redistribute it and/or modify it
// under the terms of the GNU General Public License as published by
@@ -75,7 +75,7 @@ abstract class DbgVariableCommands extends ParameterizedCommand {
throw new InvalidCommandException
("wrong number of parameters");
case 0:
- cli.outWriter.println(cli.dbgvars.toString());
+ cli.dbgvars.print(cli.outWriter);
break;
case 1:
String var = input.parameter(0);
diff --git a/frysk-core/frysk/hpd/DbgVariables.java b/frysk-core/frysk/hpd/DbgVariables.java
index 9516abc..950d356 100644
--- a/frysk-core/frysk/hpd/DbgVariables.java
+++ b/frysk-core/frysk/hpd/DbgVariables.java
@@ -1,6 +1,6 @@
// This file is part of the program FRYSK.
//
-// Copyright 2006, 2007, Red Hat Inc.
+// Copyright 2006, 2007, 2008, Red Hat Inc.
//
// FRYSK is free software; you can redistribute it and/or modify it
// under the terms of the GNU General Public License as published by
@@ -40,12 +40,14 @@
package frysk.hpd;
import java.util.SortedMap;
+import java.util.Map;
import java.util.TreeMap;
import java.util.LinkedList;
import java.util.Arrays;
import java.lang.Integer;
import java.util.Iterator;
import java.util.List;
+import java.io.PrintWriter;
/**
* Debugger variable accessible through the "set" command.
@@ -184,4 +186,13 @@ public class DbgVariables {
CompletionFactory.padSingleCandidate(candidates);
return 0;
}
+
+ public void print(PrintWriter out) {
+ for (Iterator i = vars.entrySet().iterator(); i.hasNext(); ) {
+ Map.Entry e = (Map.Entry) i.next();
+ out.print(e.getKey());
+ out.print("=");
+ out.println(((Value) e.getValue()).getValue());
+ }
+ }
}
next reply other threads:[~2008-03-01 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 17:56 Tom Tromey [this message]
2008-03-01 19:57 ` Mark Wielaard
2008-03-01 20:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3lk52gyrh.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=frysk@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).