From: Mark Wielaard <mark@klomp.org>
To: frysk@sourceware.org
Cc: cagney@sourceware.org
Subject: Re: [SCM] master: Extract TaskAttachedObserverXXX from TaskObserver, clarifying status.
Date: Tue, 18 Mar 2008 11:36:00 -0000 [thread overview]
Message-ID: <1205840174.3390.36.camel@dijkstra.wildebeest.org> (raw)
In-Reply-To: <20080317172731.3654.qmail@sourceware.org>
Hi Andrew,
On Mon, 2008-03-17 at 17:27 +0000, cagney@sourceware.org wrote:
> commit ec2bf1299f4d201f2452558aafd0880c680c729c
> Author: Andrew Cagney <cagney@redhat.com>
> Date: Mon Mar 17 13:23:23 2008 -0400
>
> Extract TaskAttachedObserverXXX from TaskObserver, clarifying status.
>
> frysk-core/frysk/bindir/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * fstep.java: Update; using TaskAttachedObserverXXX.
>
> frysk-core/frysk/ftrace/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * Ftrace.java: Update; using TaskAttachedObserverXXX.
>
> frysk-core/frysk/hpd/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * ShellCommand.java: Update; using TaskAttachedObserverXXX.
> * StartRun.java: Ditto.
>
> frysk-core/frysk/proc/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * TaskObserver.java (Attached): Move to ...
> * TaskAttachedObserverXXX.java: ... here.
> * StressAttachDetachSignaledTask.java: Ditto.
> * StressAttachDetachRapidlyCloningMainTask.java: Update.
> * StressAttachDetachManyTasks.java: Update.
> * TestTaskObserverInstruction.java: Update.
> * TestTaskObserverInstructionSigReturn.java: Update.
> * TestTaskSyscallObserver.java: Update.
> * TestTaskObserver.java: Update.
> * Host.java: Update.
> * Task.java: Update.
> * TestBreakpoints.java: Update.
> * TestInstructions.java: Update.
> * TestRun.java: Update.
>
> frysk-core/frysk/proc/dead/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * DeadHost.java: Update; using TaskAttachedObserverXXX;
> * TestLinuxCore.java: Update.
> * DeadTask.java: Ditto.
>
> frysk-core/frysk/proc/dummy/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * DummyHost.java: Update; using TaskAttachedObserverXXX.
> * DummyTask.java: Ditto.
>
> frysk-core/frysk/proc/live/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * LinuxPtraceHost.java: Update; using TaskAttachedObserverXXX.
> * TestTaskObserverCode.java: Ditto.
> * TestTaskObserverBlocked.java: Ditto.
> * TestRuntimeIsa.java: Ditto.
> * LinuxWaitBuilder.java: Ditto.
> * LinuxPtraceTask.java: Ditto.
>
> frysk-core/frysk/stepping/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * TestFirstInstruction.java: Update; using
> TaskAttachedObserverXXX.
>
> frysk-core/frysk/testbed/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * OffspringType.java: Update; using TaskAttachedObserverXXX.
>
> frysk-core/frysk/util/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * ProcRunUtil.java: Update; using TaskAttachedObserverXXX.
>
> frysk-gui/frysk/gui/monitor/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * actions/RunExternal.java: Update; using TaskAttachedObserverXXX.
> * MainWindow.java: Ditto.
>
> frysk-gui/frysk/gui/srcwin/ChangeLog
> 2008-03-17 Andrew Cagney <cagney@redhat.com>
>
> * SourceWindowFactory.java: Update; using TaskAttachedObserverXXX.
What is your plan forward here? In the comments it says:
> +++ b/frysk-core/frysk/proc/TaskAttachedObserverXXX.java
> @@ -40,21 +40,20 @@
> package frysk.proc;
>
> /**
> - * Interface to be used with Host.requestFindProc.
> + * Interface used to notify of a Task that has has been attached, and
> + * is about to resume execution in that state. Only after a Task has
> + * been attached can its internals be manipulated (registers, memory,
> + * auxv).
> + *
> + * XXX: This observer only works on un-attached tasks.
> + *
> + * XXX: This is an internal observer used to test the attached /
> + * detached state transitions. It was never intended to escape into
> + * the wild and is currently being re-captured.
> */
All the cases you changed seemed to use it indeed as described. Indicate
that they wanted to capture a specific process to be debugged/attached
and then when it was start their processing. How do you see this being
done in the future?
Thanks,
Mark
parent reply other threads:[~2008-03-18 11:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20080317172731.3654.qmail@sourceware.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205840174.3390.36.camel@dijkstra.wildebeest.org \
--to=mark@klomp.org \
--cc=cagney@sourceware.org \
--cc=frysk@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).