* What does brokenIfUtraceXXX() test for?
@ 2007-07-02 16:06 Mark Wielaard
2007-07-04 19:19 ` Andrew Cagney
0 siblings, 1 reply; 2+ messages in thread
From: Mark Wielaard @ 2007-07-02 16:06 UTC (permalink / raw)
To: frysk
Hi,
I am seeing two failures on 2.6.21-1.3228.fc7 x86 SMP:
testTerminateKillKILL(frysk.proc.TestTaskTerminateObserver)junit.framework.AssertionFailedError: terminating value expected:<-9> but was:<128>
testTerminatingKillKILL(frysk.proc.TestTaskTerminateObserver)junit.framework.AssertionFailedError: terminating value expected:<-9> but was:<128>
That are guarded by brokenIfUtraceXXX() which has as explanation:
/**
* A method that returns true, and prints broken, when the build
* kernel includes UTRACE.
*/
So, tests guarded by that ever never expected to succeed with utrace
enabled? Or is it more subtle than that? Both bugs referenced through
these guards (#3525 and #3489) are closed already.
Cheers,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: What does brokenIfUtraceXXX() test for?
2007-07-02 16:06 What does brokenIfUtraceXXX() test for? Mark Wielaard
@ 2007-07-04 19:19 ` Andrew Cagney
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2007-07-04 19:19 UTC (permalink / raw)
To: Mark Wielaard; +Cc: frysk
See bug 3639. Seems fixing it slipped through the cracks, I
fixed/closed the bug. 3489 contains a hidden references 3639 in one of
the comments; I've also made that more obvious.
As for brokenIfUtraceXXX, be careful to not read anything into it. The
test has an unresolved problem, see BUG XXXXX :-)
Mark Wielaard wrote:
> Hi,
>
> I am seeing two failures on 2.6.21-1.3228.fc7 x86 SMP:
>
> testTerminateKillKILL(frysk.proc.TestTaskTerminateObserver)junit.framework.AssertionFailedError: terminating value expected:<-9> but was:<128>
> testTerminatingKillKILL(frysk.proc.TestTaskTerminateObserver)junit.framework.AssertionFailedError: terminating value expected:<-9> but was:<128>
>
> That are guarded by brokenIfUtraceXXX() which has as explanation:
>
> /**
> * A method that returns true, and prints broken, when the build
> * kernel includes UTRACE.
> */
>
> So, tests guarded by that ever never expected to succeed with utrace
> enabled? Or is it more subtle than that? Both bugs referenced through
> these guards (#3525 and #3489) are closed already.
>
> Cheers,
>
> Mark
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-04 19:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-02 16:06 What does brokenIfUtraceXXX() test for? Mark Wielaard
2007-07-04 19:19 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).