Re: frysk-core/frysk stack/Frame.java stack/Change ...

Re: frysk-core/frysk stack/Frame.java stack/Change ...

[Phil Muldoon]

npremji@sourceware.org wrote:
> 	frysk/proc/CL
> 	* IsaIA32.java (regDefs): Expanded "efl" to "eflags".
>   

Just as a note, this broke CoredumpAction (and TestFCore tests) which 
continued to use efl instead of eflags. I'll fix it in the refactored 
version, but there could be other cases elsewhere relying on the name 
efl over eflags. Might  be worth investigation

Regards

Phil

Re: frysk-core/frysk stack/Frame.java stack/Change ...

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

On Mon, 2007-07-30 at 19:01 -0500, Phil Muldoon wrote:
> npremji@sourceware.org wrote:
> > 	frysk/proc/CL
> > 	* IsaIA32.java (regDefs): Expanded "efl" to "eflags".
> >   
> 
> Just as a note, this broke CoredumpAction (and TestFCore tests) which 
> continued to use efl instead of eflags. I'll fix it in the refactored 
> version, but there could be other cases elsewhere relying on the name 
> efl over eflags. Might  be worth investigation

A quick scan didn't show any other uses of the old name. x86_64 already
used the eflags name. To get closer to zero fail again on x86 I
committed the trivial fix, and removed some left over debug output in
the code.

2007-07-31  Mark Wielaard  <mwielaard@redhat.com>

    * StacktraceAction.java (printTasks): Remove debug println.
    * CoredumpAction.java (fillENotePrstatus): Rename elf to elflags.


Cheers,

Mark

[-- Attachment #2: elflags.patch --]
[-- Type: text/x-patch, Size: 2084 bytes --]

Index: frysk-core/frysk/util/CoredumpAction.java
===================================================================
RCS file: /cvs/frysk/frysk-core/frysk/util/CoredumpAction.java,v
retrieving revision 1.17
diff -u -r1.17 CoredumpAction.java
--- frysk-core/frysk/util/CoredumpAction.java	30 Jul 2007 16:51:39 -0000	1.17
+++ frysk-core/frysk/util/CoredumpAction.java	31 Jul 2007 11:17:57 -0000
@@ -1,6 +1,6 @@
 //This file is part of the program FRYSK.
 
-//Copyright 2006, Red Hat Inc.
+//Copyright 2006, 2007 Red Hat Inc.
 
 //FRYSK is free software; you can redistribute it and/or modify it
 //under the terms of the GNU General Public License as published by
@@ -287,7 +287,7 @@
 
         String regMap[] = { "ebx", "ecx", "edx", "esi", "edi", "ebp", "eax",
                            "ds", "es", "fs", "gs", "orig_eax", "eip", "cs",
-                           "efl", "esp", "ss" };
+                           "eflags", "esp", "ss" };
 
         for (int i = 0; i < regMap.length; i++)
           prStatus.setPrGPReg(
Index: frysk-core/frysk/util/StacktraceAction.java
===================================================================
RCS file: /cvs/frysk/frysk-core/frysk/util/StacktraceAction.java,v
retrieving revision 1.21
diff -u -r1.21 StacktraceAction.java
--- frysk-core/frysk/util/StacktraceAction.java	27 Jul 2007 21:46:27 -0000	1.21
+++ frysk-core/frysk/util/StacktraceAction.java	31 Jul 2007 11:17:57 -0000
@@ -1,6 +1,6 @@
 // This file is part of the program FRYSK.
 //
-// Copyright 2005, Red Hat Inc.
+// Copyright 2005, 2007 Red Hat Inc.
 //
 // FRYSK is free software; you can redistribute it and/or modify it
 // under the terms of the GNU General Public License as published by
@@ -150,7 +150,6 @@
     while (iter.hasNext())
       {
 	Task task =  (Task) iter.next();
-	System.out.println("StacktraceAction.printTasks() printSourceLibrary " + printSourceLibrary);
 	StackFactory.printTaskStackTrace(printWriter,task,elfOnly,printParameters,printScopes,fullpath,printSourceLibrary);
       }
     logger.log(Level.FINE, "{0} exiting printTasks\n", this);

Re: frysk-core/frysk stack/Frame.java stack/Change ...

[Sami Wagiaalla]

Nurdin,
> 	frysk/stack/CL
> 	* Frame.java (getRegisterValue): Added.
[...]

> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/stack/Frame.java.diff?cvsroot=frysk&r1=1.10&r2=1.11
>   
Does/should this replace getRigerster(int reg) ?

Re: frysk-core/frysk stack/Frame.java stack/Change ...

[Nurdin Premji]

Sami Wagiaalla wrote:
> Nurdin,
>>     frysk/stack/CL
>>     * Frame.java (getRegisterValue): Added.
> [...]
>
>> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/stack/Frame.java.diff?cvsroot=frysk&r1=1.10&r2=1.11 
>>
>>   
> Does/should this replace getRigerster(int reg) ?
>
Yup, it will soon.