From: Andrew Cagney <cagney@redhat.com>
To: Mark Wielaard <mwielaar@redhat.com>
Cc: frysk@sourceware.org
Subject: putting Ptrace back to 64-bit
Date: Thu, 02 Aug 2007 02:58:00 -0000 [thread overview]
Message-ID: <46B14863.60601@redhat.com> (raw)
Mark,
I don't understand the rationale behind this change:
2007-07-30 Mark Wielaard <mwielaard@redhat.com>
* FileDescriptor.java (read): Make start and length ints.
(write): Likewise.
* Ptrace.java (peek): Make length and offset ints.
* StatelessFile.java (pread): Make start and length ints.
(pwrite): Likewise.
* TestFileDescriptor.java (IO.op): Likewise.
(assertArrayIndexOutOfBounds): Likewise.
(testReadOutOfBounds): Likewise.
(testWriteOutOfBounds): Likewise.
* TestPtrace.java (verifyOutOfBounds): Make length and offset ints.
* TestStatelessFile.java: Make start and length ints.
* cni/Errno.cxx (verifyBounds): Make start and length ints.
* cni/Errno.hxx: Likewise.
* cni/FileDescriptor.cxx (read): Make start and length jints.
(write): Likewise.
* cni/Ptrace.cxx (peek): Make length and offset jints.
* cni/StatelessFile.cxx (pread): Make start and length jints.
(pwrite): Likewise.
It forces calling code to contend with Java's bone-head "int" is 32-bits
and be damed. Having all of these "long", which I only just went
through and cleaned up, avoided all that.
The only thing missing was for inua to be matched to this style.
Andrew
next reply other threads:[~2007-08-02 2:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 2:58 Andrew Cagney [this message]
2007-08-02 8:40 ` Mark Wielaard
2007-08-02 12:37 ` Andrew Cagney
2007-08-02 14:00 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B14863.60601@redhat.com \
--to=cagney@redhat.com \
--cc=frysk@sourceware.org \
--cc=mwielaar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).