From: Phil Muldoon <pmuldoon@redhat.com>
To: frysk@sourceware.org
Subject: Re: frysk-core/frysk/proc Breakpoint.java IsaIA32. ...
Date: Wed, 22 Aug 2007 15:11:00 -0000 [thread overview]
Message-ID: <46CC5226.8040607@redhat.com> (raw)
In-Reply-To: <20070115134847.31787.qmail@sourceware.org>
mark@sourceware.org wrote:
> CVSROOT: /cvs/frysk
> Module name: frysk-core
> Changes by: mark@sourceware.org 2007-01-15 13:48:47
>
> Modified files:
> frysk/proc : Breakpoint.java IsaIA32.java IsaX8664.java
> LinuxIa32On64.java LinuxPtraceTaskState.java
> TestTaskObserverInstruction.java
> TestTaskObserverInstructionAndCode.java
>
> Log message:
> Fixes bug #3676
> * Breakpoint.java (stepDone): Only set if still installed.
> (isInstalled): new method.
> (toString): Prettify.
> * IsaIA32.java (isTaskStepped): Reset flag.
> * IsaX8664.java (isTaskStepped): Likewise.
>
Mark,
As we talked about on irc, and in addition to looking at this code in
preparation for hardware watchpoints, can I make a small recommendation
here?
isTaskStepped(task) is a query, and should imo not be altering any debug
registers after the fact.
Can I propose a split into:
isTaskStepped(task) and setTaskStepped(task)
Does that make better sense?
Regards
Phil
next parent reply other threads:[~2007-08-22 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070115134847.31787.qmail@sourceware.org>
2007-08-22 15:11 ` Phil Muldoon [this message]
2007-08-22 18:08 ` Mark Wielaard
2007-08-22 21:47 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CC5226.8040607@redhat.com \
--to=pmuldoon@redhat.com \
--cc=frysk@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).