public inbox for
 help / color / mirror / Atom feed
* ISA checks for factories
@ 2007-10-03  8:36 Phil Muldoon
  2007-10-03 19:43 ` Andrew Cagney
  0 siblings, 1 reply; 4+ messages in thread
From: Phil Muldoon @ 2007-10-03  8:36 UTC (permalink / raw)
  To: Frysk Hackers

I've written several factories to decide what class to instantiate 
depending on the ISA. These usually end up as hacks, probably because I 
do not understand something quite right, or there is no real decent  
"What ISA does this task/proc belong" discovery.

I can instance check an ISA with:

Isa isa = proc.getIsa();
if (isa instanceof IsaIA32) ....

and so on, but that will not work for 32 on 64 ISAs. For example, on a 
32 bit process on a 64 bit system, the instance returned would be


And those cannot be instance checked as they are package private, while 
the "native" ISAs are public.

So what is the solution here? Open the scope of the xxOnxx ISAs? I get 
the feeling that instanceof checks tell me that we need to work on a 
better solution anyway. Reverting to reflection screams hack to me.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-10-09  9:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-03  8:36 ISA checks for factories Phil Muldoon
2007-10-03 19:43 ` Andrew Cagney
2007-10-09  7:53   ` Phil Muldoon
2007-10-09  9:16     ` Phil Muldoon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).