From: Andrew Cagney <cagney@redhat.com>
To: Stan Cox <scox@redhat.com>
Cc: Frysk List <frysk@sourceware.org>
Subject: Re: generating type tests
Date: Mon, 15 Oct 2007 16:56:00 -0000 [thread overview]
Message-ID: <47139B3A.3000101@redhat.com> (raw)
In-Reply-To: <1192223570.2947.145.camel@multics.rdu.redhat.com>
Stan Cox wrote:
> TypeEntry.java:
> -Add getUnionType
> -case DwTag.UNION_TYPE_ invoke getUnionType
> -case DwTag.STRUCTURE_TYPE_ remove classType.setTypedefFIXME
> -case DwTag.VOLATILE_TYPE_: new
> -case DwTag.CONST_TYPE_: new
>
> ArrayType.java:
> -Add public void toPrint(String s, PrintWriter writer)
> This is to support the odd C syntax for pointer to array where the
> pointer designation is embedded: int (* x) [2]. Using 1.5's
> String.format would be nicer
>
> PointerType.java:
> -Add public void toPrint(String s, PrintWriter writer)
> Similar to above to handle pointer to array
>
> TypeDecorator.java
> -special case PointerType so 'const int * x' and 'int * const x' are
> handled properly
>
> CompositeType.java:
> -Add public void toPrint(int indentation, PrintWriter writer)
> -if member is a CompositeType invoke toPrint with indentation+2
> -special case pointer to array case
>
Can you post the patch? If you see an apparent need to add C specific
"special cases" then there might have a problem with the code.
Especially when frysk needs to be able to handle more than just C/C++.
Time for the tree/visitor pattern?
Andrew
next prev parent reply other threads:[~2007-10-15 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 21:18 Stan Cox
2007-10-12 22:54 ` Andrew Cagney
2007-10-15 2:10 ` Stan Cox
2007-10-15 16:50 ` Andrew Cagney
2007-10-16 19:47 ` Stan Cox
2007-10-17 11:12 ` Stan Cox
2007-10-15 16:56 ` Andrew Cagney [this message]
2007-10-15 19:13 ` Stan Cox
2007-10-18 16:16 ` Stan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47139B3A.3000101@redhat.com \
--to=cagney@redhat.com \
--cc=frysk@sourceware.org \
--cc=scox@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).