From: Sami Wagiaalla <swagiaal@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: frysk <frysk@sourceware.org>
Subject: Re: Find right frame index in TestDebugInfoStackTrace.java
Date: Fri, 26 Oct 2007 15:53:00 -0000 [thread overview]
Message-ID: <47220D62.6020002@redhat.com> (raw)
In-Reply-To: <1193413323.2931.15.camel@hermans.wildebeest.org>
Thanks mark I so annoyed with this test :)
Mark Wielaard wrote:
> Hi,
>
> On a multi-core machine the TestDebugInfoStackTrace would sometimes fail
> because the "signal_parent" task could still be in kernel, glibc signal
> or kill helper functions. The following patch tries to find the right
> index in that thread and uses that for the tests.
>
> 2007-10-26 Mark Wielaard <mwielaard@redhat.com>
>
> * TestDebugInfoStackTrace.java (frameAssertions): Find and use
> correct thread_parent task frame index.
>
> This makes this test reliably pass on my machine now even with different
> frame index depths. But I found the test really hard to read so I
> wouldn't mind someone double checking the fix.
>
> Cheers,
>
> Mark
>
prev parent reply other threads:[~2007-10-26 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 15:42 Mark Wielaard
2007-10-26 15:53 ` Sami Wagiaalla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47220D62.6020002@redhat.com \
--to=swagiaal@redhat.com \
--cc=frysk@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).