public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@redhat.com>
To: Mark Wielaard <mwielaar@redhat.com>
Cc: frysk@sourceware.org
Subject: Re: [SCM]  master: Use libunwind cursor to get at CFA.
Date: Mon, 03 Dec 2007 16:19:00 -0000	[thread overview]
Message-ID: <47542CA6.20509@redhat.com> (raw)
In-Reply-To: <20071203105946.11374.qmail@sourceware.org>

mark@sourceware.org wrote:
>     frysk-core/frysk/stack/ChangeLog
>     2007-12-03  Mark Wielaard  <mwielaard@redhat.com>
>     
>            * LibunwindFrame.java (getFrameIdentifier): Get CFA from cursor.
>   

This isn't right.

The confusion comes from what libunwind considers to be the cursor's 
CFA.  It returns what you're more likely to recognize as the  
inner-to-cursor's CFA and not the cursor''s CFA.  Effectively the 
current frame's SP, in fact:

    case UNW_X86_64_CFA:
    case UNW_X86_64_RSP:
      if (write)
        return -UNW_EREADONLYREG;
      *valp = c->dwarf.cfa;
      return 0;

Andrew



       reply	other threads:[~2007-12-03 16:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071203105946.11374.qmail@sourceware.org>
2007-12-03 16:19 ` Andrew Cagney [this message]
2007-12-03 20:49   ` Mark Wielaard
2007-12-04 14:42     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47542CA6.20509@redhat.com \
    --to=cagney@redhat.com \
    --cc=frysk@sourceware.org \
    --cc=mwielaar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).